Skip to content

repl: fix top level await with surrogate characters - #39931

Closed
Mesteery wants to merge 2 commits into
nodejs:masterfrom
Mesteery:repl-await-surrogates
Closed

repl: fix top level await with surrogate characters#39931
Mesteery wants to merge 2 commits into
nodejs:masterfrom
Mesteery:repl-await-surrogates

Conversation

@Mesteery

@MesteeryMesteery commented Aug 29, 2021

Copy link
Copy Markdown
Contributor

Fixes: #39929

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. labels Aug 29, 2021
Trott
Trott reviewed Aug 29, 2021
View reviewed changes
Comment threadlib/internal/repl/await.js Outdated
@TrottTrott added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Aug 29, 2021
@Mesteery

Mesteery commented Aug 29, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

This does not work for entries like await "😀😀😀";"😀".
edit: I think I finally succeeded.
edit: It's more complicated than I thought. 😅

@MesteeryMesteery reopened this Aug 29, 2021
@Mesteery
Mesteery deleted the repl-await-surrogates branch August 29, 2021 17:29
@Mesteery
Mesteery restored the repl-await-surrogates branch August 29, 2021 18:01
@Trott

Trott commented Aug 29, 2021

Copy link
Copy Markdown
Member

This does not work for entries like await "😀😀😀";"😀".
edit: I think I finally succeeded.
edit: It's more complicated than I thought. 😅

While getting it exactly right is, of course, preferred, it's totally OK to land something that is an improvement that still leaves some edge cases unsolved. await "😀😀😀";"😀" doesn't work currently, so it's OK if your fix doesn't fix that.

@MesteeryMesteery reopened this Aug 29, 2021
@Mesteery
Mesteeryforce-pushed the repl-await-surrogates branch from b14b25e to 458a9fdCompareAugust 29, 2021 22:38
@Mesteery

Mesteery commented Aug 29, 2021

Copy link
Copy Markdown
ContributorAuthor

Ok, thanks! Finally I succeeded, and I don't know why I was looking for a complex solution. Just break the surrogates, so the array has the same length as the string and the surrogates will normally not be broken at the end (unless there is a bug with some indexes or acorn, but I doubt it)

BridgeAR
BridgeAR approved these changes Aug 30, 2021
View reviewed changes

@BridgeARBridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VoltrexKeyvaVoltrexKeyva added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Aug 30, 2021
@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 30, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 30, 2021
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 2, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 2, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Sep 6, 2021•
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39820/ 💚

Leko
Leko approved these changes Sep 7, 2021
View reviewed changes
@targostargos self-assigned this Sep 8, 2021
targos pushed a commit to targos/node that referenced this pull request Sep 8, 2021
@Mesteery@targos
repl: fix top level await with surrogate characters
addb30f
Fixes: nodejs#39929
PR-URL: nodejs#39931
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
@targos

targos commented Sep 8, 2021

Copy link
Copy Markdown
Member

Landed in addb30f

@targostargos closed this Sep 8, 2021
@targostargos removed their assignment Sep 8, 2021
@Mesteery
Mesteery deleted the repl-await-surrogates branch September 8, 2021 19:16
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@Mesteery@BethGriggs
repl: fix top level await with surrogate characters
d6124d8
Fixes: #39929
PR-URL: #39931
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Sep 21, 2021
Merged
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott left review comments
@jasnelljasnelljasnell approved these changes
@BridgeARBridgeARBridgeAR approved these changes
+1 more reviewer
@LekoLekoLeko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.replIssues and PRs related to the REPL subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

await an expression with surrogate characters raises a SyntaxError

9 participants

@Mesteery@Trott@nodejs-github-bot@targos@jasnell@Leko@BridgeAR@aduh95@VoltrexKeyva