Uh oh!
There was an error while loading. Please reload this page.
buffer: fix writeInt{B,L}E for some negative values - #3994
Closed
pabigot wants to merge 1 commit into
Closed
Conversation
The algorithm used to convert negative values to hex generates incorrect values when the low byte(s) of the value are zero because a carried subtraction is applied prematurely. Fixesnodejs#3992 Signed-off-by: Peter A. Bigot <pab@pabigot.com>
evanlucas
commented
Nov 23, 2015
Contributor
/cc @trevnorris |
trevnorris
commented
Nov 23, 2015
Contributor
CI https://ci.nodejs.org/job/node-test-pull-request/817/ If all's good then LGTM |
pabigot
commented
Nov 23, 2015
ContributorAuthor
@trevnorris From what I can see the CI build failed, but I'm at a loss as to why. At least part of it seems to be due to git failures. If you can see something that's due to my change please point it out and I'll work to fix it. |
Fishrock123
commented
Nov 23, 2015
Contributor
Hmm, cc @nodejs/build that doesn't seem to have run all of the test jobs? |
trevnorris
commented
Nov 23, 2015
Contributor
Trying this again: https://ci.nodejs.org/job/node-test-pull-request/818/ |
orangemocha
commented
Nov 23, 2015
Contributor
Jenkins is currently messed up again. See nodejs/build#263 |
orangemocha
commented
Nov 25, 2015
Contributor
Jenkins is working again. New CI run: https://ci.nodejs.org/job/node-test-pull-request/842/ |
pabigot
commented
Nov 25, 2015
ContributorAuthor
@orangemocha thanks for resubmitting that. AFAICT the two new failures are due to networking errors. If these aren't expected intermittent problems with the CI infrastructure and you think they could be due to my patch let me know; otherwise I'm going to claim the results are "pass" and move on. |
orangemocha
commented
Nov 25, 2015
Contributor
I can confirm that those failures are unrelated to this PR. |
trevnorris pushed a commit
that referenced
this pull request
Dec 1, 2015
The algorithm used to convert negative values to hex generates incorrect values when the low byte(s) of the value are zero because a carried subtraction is applied prematurely. Fixes: #3992 PR-URL: #3994 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Signed-off-by: Peter A. Bigot <pab@pabigot.com>
trevnorris
commented
Dec 1, 2015
Contributor
Thanks much! Landed in bea6742. |
rvagg pushed a commit
that referenced
this pull request
Dec 5, 2015
The algorithm used to convert negative values to hex generates incorrect values when the low byte(s) of the value are zero because a carried subtraction is applied prematurely. Fixes: #3992 PR-URL: #3994 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Signed-off-by: Peter A. Bigot <pab@pabigot.com>
This was referenced Dec 8, 2015
MylesBorins pushed a commit
that referenced
this pull request
Dec 15, 2015
The algorithm used to convert negative values to hex generates incorrect values when the low byte(s) of the value are zero because a carried subtraction is applied prematurely. Fixes: #3992 PR-URL: #3994 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Signed-off-by: Peter A. Bigot <pab@pabigot.com>
Closed
jasnell pushed a commit
that referenced
this pull request
Dec 17, 2015
The algorithm used to convert negative values to hex generates incorrect values when the low byte(s) of the value are zero because a carried subtraction is applied prematurely. Fixes: #3992 PR-URL: #3994 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Signed-off-by: Peter A. Bigot <pab@pabigot.com>
jasnell pushed a commit
that referenced
this pull request
Dec 23, 2015
The algorithm used to convert negative values to hex generates incorrect values when the low byte(s) of the value are zero because a carried subtraction is applied prematurely. Fixes: #3992 PR-URL: #3994 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Signed-off-by: Peter A. Bigot <pab@pabigot.com>
scovetta pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
The algorithm used to convert negative values to hex generates incorrect values when the low byte(s) of the value are zero because a carried subtraction is applied prematurely. Fixes: nodejs#3992 PR-URL: nodejs#3994 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Signed-off-by: Peter A. Bigot <pab@pabigot.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The algorithm used to convert negative values to hex generates incorrect
values when the low byte(s) of the value are zero because a carried
subtraction is applied prematurely.
Fixes#3992
Signed-off-by: Peter A. Bigot pab@pabigot.com