lib,repl: ignore `canBeRequiredByUsers` built-in by XadillaX · Pull Request #39942 · nodejs/node

XadillaX · 2021-08-30T10:11:49Z

e.g. wasi under no --experimental-wasi-unstable-preview1 flag
shouldn't be pre-required.

Mesteery · 2021-08-30T10:15:10Z

Fixes: #39911

tniessen

This might need to be semver-major.

tniessen · 2021-08-30T16:58:19Z

Most of this function seems to emulate what execFile does (promisified if a Promise is really necessary here).

e.g. `wasi` under no `--experimental-wasi-unstable-preview1` flag shouldn't be pre-required.

BridgeAR

LGTM

BridgeAR · 2021-08-31T09:56:02Z

@tniessen I also wonder about the semverness. So far most things in the REPL were not considered semver-major if it did not change the public API. Since it's mostly experimental libraries, I would be fine to call it a fix while I would go with semver-major if anyone would argue for it.

nodejs-github-bot · 2021-09-06T10:55:15Z

CI: https://ci.nodejs.org/job/node-test-pull-request/39818/

e.g. `wasi` under no `--experimental-wasi-unstable-preview1` flag shouldn't be pre-required. PR-URL: #39942 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>

XadillaX · 2021-09-07T02:53:41Z

Landed in c7222b3

e.g. `wasi` under no `--experimental-wasi-unstable-preview1` flag shouldn't be pre-required. PR-URL: #39942 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>

XadillaX linked an issue Aug 30, 2021 that may be closed by this pull request
Modules under flags should not be exposed in the REPL if the flag is not set #39911
Closed

nodejs-github-bot added needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. labels Aug 30, 2021

XadillaX force-pushed the add-builin-libs-to-object branch from f61ea9e to 032c4f2Compare August 30, 2021 10:20

aduh95 reviewed Aug 30, 2021
View reviewed changes