Uh oh!
There was an error while loading. Please reload this page.
doc: make version picker usable on mobile - #39958
Closed
evanlucas wants to merge 1 commit into
Closed
Conversation
evanlucas
marked this pull request as ready for review
August 31, 2021 15:47
lpinca
approved these changes
Aug 31, 2021
aduh95
approved these changes
Aug 31, 2021
aduh95
left a comment
Contributor
There was a problem hiding this comment.
I'd prefer if instead we apply display: inline only if the user screen is bigger than 576px, instead of applying display: inline all the time and overwrite it with display: block when the screen is small. Non-blocking though.
evanlucas
commented
Sep 2, 2021
ContributorAuthor
@aduh95 okay, pushed another commit with the suggested change. PTAL. Thanks! |
aduh95
reviewed
Sep 2, 2021
Comment on lines
731
to
737
Contributor
There was a problem hiding this comment.
This block doesn't seem to be necessary anymore.
Suggested change
| @mediaonly screen and (max-width:576px) { | |
| #gtoc>ul>li { | |
| display: block; | |
| border-right: none; | |
| } | |
| } |
ContributorAuthor
There was a problem hiding this comment.
ack, removed it. Thanks!
tniessen
approved these changes
Sep 2, 2021
jasnell
approved these changes
Sep 3, 2021
DerekNonGeneric
approved these changes
Sep 5, 2021
DerekNonGeneric
commented
Sep 21, 2021
Contributor
@evanlucas, seems like this is good to go as soon as the review point made by @aduh95 is addressed (or not). I would like to see this land either way, but would need to rebase due to having multiple commits in the PR (please handle this). |
evanlucas
commented
Sep 22, 2021
ContributorAuthor
@DerekNonGeneric hey sorry, just now have time to get back to this. I'll get the suggested changes added and get this rebased today. Thanks! |
This makes the version picker usable on mobile devices. Previously, the version picker was difficult to select from. This change makes the #gtoc > ul > li elements have a display of `block` instead of `inline`.
evanlucasforce-pushed
the
evanlucas/mobiledocs
branch
from
September 22, 2021 18:01
8166d00 to
031cd13Compareaduh95
approved these changes
Sep 22, 2021
Contributor
Landed in 24cc239...c89d519 |
nodejs-github-bot pushed a commit
that referenced
this pull request
Sep 22, 2021
This makes the version picker usable on mobile devices. Previously, the version picker was difficult to select from. This change makes the #gtoc > ul > li elements have a display of `block` instead of `inline`. PR-URL: #39958 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
targos pushed a commit
that referenced
this pull request
Oct 4, 2021
This makes the version picker usable on mobile devices. Previously, the version picker was difficult to select from. This change makes the #gtoc > ul > li elements have a display of `block` instead of `inline`. PR-URL: #39958 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the version picker usable on mobile devices.
Previously, the version picker was difficult to select from. This
change makes the #gtoc > ul > li elements have a display
of
blockinstead ofinline.Before:
After: