Uh oh!
There was an error while loading. Please reload this page.
crypto: check webcrypto asymmetric key types during importKey - #39962
Closed
panva wants to merge 1 commit into
Closed
crypto: check webcrypto asymmetric key types during importKey#39962panva wants to merge 1 commit into
panva wants to merge 1 commit into
Conversation
panva
commented
Aug 31, 2021
MemberAuthor
cc @nodejs/crypto |
jasnell
approved these changes
Aug 31, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
Contributor
Landed in 0c6f345...5d34ef5 |
nodejs-github-bot pushed a commit
that referenced
this pull request
Sep 7, 2021
PR-URL: #39962 Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit
that referenced
this pull request
Sep 21, 2021
PR-URL: #39962 Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where any
KeyObject.prototype.typematching key would result in aCryptoKeydespite it being the wrongKeyObject.prototype.asymmetricKeyType