Uh oh!
There was an error while loading. Please reload this page.
doc: message.header duplication correction - #3997
Closed
bengl wants to merge 1 commit into
Closed
Conversation
Member
There was a problem hiding this comment.
LGTM but maybe link directly to message.headers without trying to describe the logic first? Something like See [message.headers][] for details on how duplicate headers are handled. That way it can't go out of sync.
bnoordhuis
commented
Nov 24, 2015
Member
LGTM with a suggestion. If other collaborators feel it's good as-is, go ahead and land it. |
evanlucas
commented
Nov 24, 2015
Contributor
I think linking will be the better solution. LGTM other than that |
cjihrig
commented
Nov 24, 2015
Contributor
LGTM with the same comment. |
The old version of the text here was slightly incorrect, so it just defers the details to the section in which they're fully described.
benglforce-pushed
the
moreheaderclarity
branch
from
November 24, 2015 17:44
7dc314a to
dc7fe51Comparebengl
commented
Nov 24, 2015
MemberAuthor
Cool, shortened it down to just what @bnoordhuis suggested. |
bnoordhuis
commented
Nov 24, 2015
Member
Thanks Bryan, landed in 6f87aa9. |
bnoordhuis pushed a commit
that referenced
this pull request
Nov 24, 2015
The old version of the text here was slightly incorrect, so it just defers the details to the section in which they're fully described. PR-URL: #3997 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins pushed a commit
that referenced
this pull request
Dec 1, 2015
The old version of the text here was slightly incorrect, so it just defers the details to the section in which they're fully described. PR-URL: #3997 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
rvagg pushed a commit
that referenced
this pull request
Dec 4, 2015
The old version of the text here was slightly incorrect, so it just defers the details to the section in which they're fully described. PR-URL: #3997 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
rvagg pushed a commit
that referenced
this pull request
Dec 5, 2015
The old version of the text here was slightly incorrect, so it just defers the details to the section in which they're fully described. PR-URL: #3997 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
This was referenced Dec 8, 2015
Closed
jasnell pushed a commit
that referenced
this pull request
Dec 17, 2015
The old version of the text here was slightly incorrect, so it just defers the details to the section in which they're fully described. PR-URL: #3997 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
jasnell pushed a commit
that referenced
this pull request
Dec 23, 2015
The old version of the text here was slightly incorrect, so it just defers the details to the section in which they're fully described. PR-URL: #3997 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old version of the text here was slightly incorrect (probably how it used to work, so it's now it's slightly more vague, deferring the details to the section in which they're already fully described.