Skip to content

doc: add more to subsystems - #39971

Closed
iam-frankqiu wants to merge 2 commits into
nodejs:masterfrom
iam-frankqiu:doc_add_subsystems
Closed

doc: add more to subsystems#39971
iam-frankqiu wants to merge 2 commits into
nodejs:masterfrom
iam-frankqiu:doc_add_subsystems

Conversation

@iam-frankqiu

@iam-frankqiuiam-frankqiu commented Sep 1, 2021

Copy link
Copy Markdown
Contributor

Add benchmarkdepstypings to subsystems.

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 1, 2021
@aduh95

aduh95 commented Sep 1, 2021

Copy link
Copy Markdown
Contributor

The full list of subsystems can be found at https://github.com/nodejs/core-validate-commit/blob/main/lib/rules/subsystem.js. Maybe we should list them all here, or replace the list with a link to the JS file.

@iam-frankqiu

iam-frankqiu commented Sep 2, 2021

Copy link
Copy Markdown
ContributorAuthor

The full list of subsystems can be found at https://github.com/nodejs/core-validate-commit/blob/main/lib/rules/subsystem.js. Maybe we should list them all here, or replace the list with a link to the JS file.

Good idea. How about this time?

tniessen
tniessen reviewed Sep 2, 2021
View reviewed changes
Comment threaddoc/guides/contributing/pull-requests.md Outdated
@iam-frankqiu

iam-frankqiu commented Sep 2, 2021

Copy link
Copy Markdown
ContributorAuthor

I don't know what's wrong with my code? I only add several lines of code in the markdown file. But the action of build-windows(windows-2022) still failed. Is it a bug? @nodejs/actions

@aduh95

aduh95 commented Sep 2, 2021

Copy link
Copy Markdown
Contributor

It is unrelated to your PR, see #39976.

aduh95
aduh95 reviewed Sep 2, 2021
View reviewed changes
Comment threaddoc/guides/contributing/pull-requests.md Outdated
Comment threaddoc/guides/contributing/pull-requests.md Outdated
@aduh95

aduh95 commented Sep 3, 2021

Copy link
Copy Markdown
Contributor

Can you fix the linter error please?

@iam-frankqiu

iam-frankqiu commented Sep 3, 2021

Copy link
Copy Markdown
ContributorAuthor

Can you fix the linter error please?

Sure.

@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 3, 2021
lpinca
lpinca approved these changes Sep 4, 2021
View reviewed changes
Comment threaddoc/guides/contributing/pull-requests.md Outdated
Ayase-252 pushed a commit that referenced this pull request Sep 15, 2021
@iam-frankqiu@Ayase-252
doc: add full list of subsystems
166e52b
PR-URL: #39971
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
@Ayase-252

Ayase-252 commented Sep 15, 2021

Copy link
Copy Markdown
Member

Landed in 166e52b

BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@iam-frankqiu@BethGriggs
doc: add full list of subsystems
bebbd22
PR-URL: #39971
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@iam-frankqiu@BethGriggs
doc: add full list of subsystems
8aad81d
PR-URL: #39971
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
@BethGriggsBethGriggs mentioned this pull request Sep 21, 2021
Merged
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@Ayase-252Ayase-252Ayase-252 approved these changes
@aduh95aduh95aduh95 approved these changes
@tniessentniessenAwaiting requested review from tniessen

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@iam-frankqiu@aduh95@Ayase-252@jasnell@lpinca@tniessen@nodejs-github-bot