Uh oh!
There was an error while loading. Please reload this page.
[v14.x Backport] fs: writeFile support AsyncIterable, Iterable & Stream as data argument - #39973
Closed
aduh95 wants to merge 3 commits into
Closed
[v14.x Backport] fs: writeFile support AsyncIterable, Iterable & Stream as data argument#39973aduh95 wants to merge 3 commits into
writeFile support AsyncIterable, Iterable & Stream as data argument#39973aduh95 wants to merge 3 commits into
Conversation
Create a utils module for isIterable(), isReadable(), and isStream(). PR-URL: nodejs#37508 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Fixes: nodejs#37391 PR-URL: nodejs#37490 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Refs: nodejs#37490 PR-URL: nodejs#39836 Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
aduh95force-pushed
the
backport-fsp-writefile-asynciterator-v14
branch
from
September 1, 2021 22:20
fcbf21e to
17b6ad6Comparetargos
approved these changes
Sep 4, 2021
targos pushed a commit
that referenced
this pull request
Sep 4, 2021
Create a utils module for isIterable(), isReadable(), and isStream(). PR-URL: #37508 Backport-PR-URL: #39973 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos
commented
Sep 4, 2021
Member
Landed in 2b0e270...fe28128 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #37508, #37490, and #39836.