Uh oh!
There was an error while loading. Please reload this page.
Closed
Conversation
lpinca
approved these changes
Sep 3, 2021
tniessen
reviewed
Sep 3, 2021
Uh oh!
There was an error while loading. Please reload this page.
There's no need to set 'false' to 'isAsync' because we've declared it before.
ghost
requested a review
from tniessenSeptember 3, 2021 22:49
tniessen
approved these changes
Sep 4, 2021
jasnell
approved these changes
Sep 4, 2021
RaisinTen
approved these changes
Sep 5, 2021
nodejs-github-bot
commented
Sep 5, 2021
Collaborator
nodejs-github-bot
commented
Sep 16, 2021
Collaborator
nodejs-github-bot
commented
Sep 17, 2021
Collaborator
targos pushed a commit
that referenced
this pull request
Sep 18, 2021
There's no need to set 'false' to 'isAsync' because we've declared it before. PR-URL: #39983 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos
commented
Sep 18, 2021
Member
Landed in 8900a46 |
BethGriggs pushed a commit
that referenced
this pull request
Sep 21, 2021
There's no need to set 'false' to 'isAsync' because we've declared it before. PR-URL: #39983 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
BethGriggs pushed a commit
that referenced
this pull request
Sep 21, 2021
There's no need to set 'false' to 'isAsync' because we've declared it before. PR-URL: #39983 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no need to set to 'false', because we will set the value according to the actual condition.