Skip to content

test: fix test-dgram-udp6-link-local-address on Windows - #40005

Closed
targos wants to merge 1 commit into
nodejs:masterfrom
targos:fix-test-udp-win
Closed

test: fix test-dgram-udp6-link-local-address on Windows#40005
targos wants to merge 1 commit into
nodejs:masterfrom
targos:fix-test-udp-win

Conversation

@targos

@targostargos commented Sep 5, 2021

Copy link
Copy Markdown
Member

This fixes the test on my machine at least.

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 5, 2021
@targostargos added dgram Issues and PRs related to the dgram subsystem / UDP. windows Issues and PRs related to the Windows platform. and removed needs-ci PRs that need a full CI run. labels Sep 5, 2021
@targos

targos commented Sep 5, 2021

Copy link
Copy Markdown
MemberAuthor

Error was:

node .\test\parallel\test-dgram-udp6-link-local-address.js
node:events:371
throw er; // Unhandled 'error' event
^
Error: getaddrinfo ENOTFOUND fe80::a030:196b:d025:69fb%vEthernet (Ethernet 2)
at GetAddrInfoReqWrap.onlookup [as oncomplete] (node:dns:71:26)
Emitted 'error' event on Socket instance at:
at GetAddrInfoReqWrap.callback (node:dgram:326:12)
at GetAddrInfoReqWrap.onlookup [as oncomplete] (node:dns:71:17) {
errno: -3008,
code: 'ENOTFOUND',
syscall: 'getaddrinfo',
hostname: 'fe80::a030:196b:d025:69fb%vEthernet (Ethernet 2)'
}

@targostargos added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 5, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 5, 2021
@nodejs-github-bot

nodejs-github-bot commented Sep 5, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39794/

@jasnell

jasnell commented Sep 5, 2021

Copy link
Copy Markdown
Member

Bunch of relevant failures in CI

@targos

targos commented Sep 5, 2021

Copy link
Copy Markdown
MemberAuthor

At least it passed on Windows 😄

@targostargos added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 5, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 5, 2021
@nodejs-github-bot

nodejs-github-bot commented Sep 5, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39800/

@targos

targos commented Sep 6, 2021

Copy link
Copy Markdown
MemberAuthor

It's fixed.

@nodejs-github-bot

nodejs-github-bot commented Sep 6, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39825/

@nodejs-github-bot

nodejs-github-bot commented Sep 6, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39839/

@targostargos added the review wanted PRs that need reviews. label Sep 7, 2021
@targos

targos commented Sep 18, 2021

Copy link
Copy Markdown
MemberAuthor

ping @nodejs/testing @jasnell

@targostargos added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 20, 2021
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 20, 2021
@github-actions

github-actionsBot commented Sep 20, 2021

Copy link
Copy Markdown
Contributor

Landed in 420cdc7...4e7fe5a

nodejs-github-bot pushed a commit that referenced this pull request Sep 20, 2021
@targos@nodejs-github-bot
test: fix test-dgram-udp6-link-local-address on Windows
4e7fe5a
PR-URL: #40005
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos
targos deleted the fix-test-udp-win branch September 20, 2021 14:11
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@targos@BethGriggs
test: fix test-dgram-udp6-link-local-address on Windows
7029db2
PR-URL: #40005
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@targos@BethGriggs
test: fix test-dgram-udp6-link-local-address on Windows
6be405b
PR-URL: #40005
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Sep 21, 2021
Merged
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes

Assignees

No one assigned

Labels

dgramIssues and PRs related to the dgram subsystem / UDP.review wantedPRs that need reviews.testIssues and PRs related to the tests.windowsIssues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@targos@nodejs-github-bot@jasnell@Trott