Uh oh!
There was an error while loading. Please reload this page.
Python str.endswith() can take a tuple of alternatives - #40017
Closed
cclauss wants to merge 1 commit into
Closed
Conversation
https://docs.python.org/3/library/stdtypes.html#str.endswith One function call should be faster than three function calls per file.
richardlau
approved these changes
Sep 6, 2021
targos
approved these changes
Sep 6, 2021
Trott
approved these changes
Sep 7, 2021
jasnell
approved these changes
Sep 7, 2021
Leko
approved these changes
Sep 7, 2021
tniessen
approved these changes
Sep 7, 2021
nodejs-github-bot
commented
Sep 7, 2021
Collaborator
Contributor
Fast-track has been requested by @BridgeAR. Please 👍 to approve. |
nodejs-github-bot
commented
Sep 8, 2021
Collaborator
This was referenced Sep 14, 2021
RaisinTen
approved these changes
Sep 19, 2021
nodejs-github-bot
commented
Sep 23, 2021
Collaborator
targos pushed a commit
that referenced
this pull request
Sep 26, 2021
https://docs.python.org/3/library/stdtypes.html#str.endswith One function call should be faster than three function calls per file. PR-URL: #40017 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos
commented
Sep 26, 2021
Member
Landed in b25a73f |
targos pushed a commit
that referenced
this pull request
Oct 4, 2021
https://docs.python.org/3/library/stdtypes.html#str.endswith One function call should be faster than three function calls per file. PR-URL: #40017 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://docs.python.org/3/library/stdtypes.html#str.endswith
One function call should be faster than three function calls per file.