Skip to content

build: only lint version numbers for pull requests - #40027

Closed
targos wants to merge 1 commit into
nodejs:masterfrom
targos:fix-lint-md
Closed

build: only lint version numbers for pull requests#40027
targos wants to merge 1 commit into
nodejs:masterfrom
targos:fix-lint-md

Conversation

@targos

@targostargos commented Sep 7, 2021

Copy link
Copy Markdown
Member

Fixes: #39850

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Sep 7, 2021
@targos

targos commented Sep 7, 2021•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

BTW, I see that lint-md also runs the JS linter. Is that intended?

Running JS linter...
Running Markdown linter...

image

aduh95
aduh95 approved these changes Sep 7, 2021
View reviewed changes

@aduh95aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@richardlau

richardlau commented Sep 7, 2021

Copy link
Copy Markdown
Member

BTW, I see that lint-md also runs the JS linter. Is that intended?

Running JS linter...
Running Markdown linter...

I believe so -- it's linting the JS within the docs:

node/Makefile

Lines 1254 to 1255 in dadea4a

# Lints the markdown documents maintained by us in the codebase.
lint-md: lint-js-doc | tools/.mdlintstamp

node/Makefile

Lines 1269 to 1279 in dadea4a

.PHONY: lint-js-doc
# Note that on the CI `lint-js-ci` is run instead.
# Lints the JavaScript code with eslint.
lint-js-doc: LINT_JS_TARGETS=doc
lint-jslint-js-doc:
@if [ "$(shell $(node_use_openssl))"!="true" ];then\
echo"Skipping $@ (no crypto)";\
else\
echo"Running JS linter...";\
$(call available-node,$(run-lint-js))\
fi

@VoltrexKeyvaVoltrexKeyva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 10, 2021
@targostargos added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 15, 2021
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 15, 2021
@github-actions

github-actionsBot commented Sep 15, 2021

Copy link
Copy Markdown
Contributor

Landed in bbd4c6e...798c0cb

nodejs-github-bot pushed a commit that referenced this pull request Sep 15, 2021
@targos@nodejs-github-bot
build: only lint version numbers for pull requests
798c0cb
Fixes: #39850
PR-URL: #40027
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos
targos deleted the fix-lint-md branch September 15, 2021 06:53
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@targos@BethGriggs
build: only lint version numbers for pull requests
49f77b5
Fixes: #39850
PR-URL: #40027
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@targos@BethGriggs
build: only lint version numbers for pull requests
01b1946
Fixes: #39850
PR-URL: #40027
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Sep 21, 2021
Merged
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@richardlaurichardlaurichardlau approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.metaIssues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

make lint-md failing for v16.x-staging in GitHub actions

7 participants

@targos@richardlau@jasnell@lpinca@aduh95@nodejs-github-bot@VoltrexKeyva