deps: V8: cherry-pick 9a607043cb31 by gengjiawen · Pull Request #40046 · nodejs/node

gengjiawen · 2021-09-09T06:40:00Z

Original commit message:

[compiler] Gracefully handle an unsupported situation
... by skipping the optimization instead of CHECK-failing.
Bug: v8:12188
Change-Id: I6709bf1c55506f3d12886efbfbb9934788cd02ce
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148132
Auto-Submit: Georg Neis <neis@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/main@{#76741}

Refs: v8/v8@9a60704

Original commit message: [compiler] Gracefully handle an unsupported situation ... by skipping the optimization instead of CHECK-failing. Bug: v8:12188 Change-Id: I6709bf1c55506f3d12886efbfbb9934788cd02ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148132 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#76741} Refs: v8/v8@9a60704

github-actions · 2021-09-09T06:42:47Z

Fast-track has been requested by @gengjiawen. Please 👍 to approve.

targos · 2021-09-09T06:44:47Z

~~I'll prepare a small release as soon as this is merged.~~
Edit: someone else will have to do it. I don't have the time anymore.

nodejs-github-bot · 2021-09-09T06:46:51Z

CI: https://ci.nodejs.org/job/node-test-pull-request/39874/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4260/ ✅

nodejs-github-bot · 2021-09-09T08:34:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/39876/ ✅

- until nodejs/node#40046 is merged

github-actions · 2021-09-09T11:45:25Z

Commit Queue failed

- Loading data for nodejs/node/pull/40046
✔ Done loading data for nodejs/node/pull/40046
----------------------------------- PR info ------------------------------------
Title deps: V8: cherry-pick 9a607043cb31 (#40046)
Author Jiawen Geng (@gengjiawen)
Branch gengjiawen:patch_v8 -> nodejs:master
Labels build, v8 engine, fast-track, needs-ci
Commits 1
- deps: V8: cherry-pick 9a607043cb31
Committers 1
- Jiawen Geng PR-URL: https://github.com/nodejs/node/pull/40046
Fixes: https://github.com/nodejs/node/issues/40030
Refs: https://github.com/v8/v8/commit/9a607043cb3161f8ceae1583807bece595388108
Reviewed-By: Michaël Zasso ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/40046
Fixes: https://github.com/nodejs/node/issues/40030
Refs: https://github.com/v8/v8/commit/9a607043cb3161f8ceae1583807bece595388108
Reviewed-By: Michaël Zasso --------------------------------------------------------------------------------
ℹ This PR was created on Thu, 09 Sep 2021 06:40:00 GMT
✔ Approvals: 1
✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/40046#pullrequestreview-749930279
ℹ This PR is being fast-tracked
✖ This PR needs to wait 162 more hours to land (or 42 hours if there is one more approval)
✔ Last GitHub Actions successful
ℹ Last V8 CI on 2021-09-09T06:46:51Z: https://ci.nodejs.org/job/node-test-commit-v8-linux/4260/
ℹ Last Full PR CI on 2021-09-09T08:34:23Z: https://ci.nodejs.org/job/node-test-pull-request/39876/
- Querying data for job/node-test-pull-request/39876/
✔ Build data downloaded
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/1217149145

github-actions · 2021-09-09T11:51:58Z

Landed in 513a979...be3af51

Original commit message: [compiler] Gracefully handle an unsupported situation ... by skipping the optimization instead of CHECK-failing. Bug: v8:12188 Change-Id: I6709bf1c55506f3d12886efbfbb9934788cd02ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148132 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#76741} Refs: v8/v8@9a60704 PR-URL: #40046Fixes: #40030 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>

Original commit message: [compiler] Gracefully handle an unsupported situation ... by skipping the optimization instead of CHECK-failing. Bug: v8:12188 Change-Id: I6709bf1c55506f3d12886efbfbb9934788cd02ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148132 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#76741} Refs: v8/v8@9a60704 PR-URL: nodejs#40046Fixes: nodejs#40030 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>

Original commit message: [compiler] Gracefully handle an unsupported situation ... by skipping the optimization instead of CHECK-failing. Bug: v8:12188 Change-Id: I6709bf1c55506f3d12886efbfbb9934788cd02ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148132 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#76741} Refs: v8/v8@9a60704 PR-URL: #40046Fixes: #40030 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>

Original commit message: [compiler] Gracefully handle an unsupported situation ... by skipping the optimization instead of CHECK-failing. Bug: v8:12188 Change-Id: I6709bf1c55506f3d12886efbfbb9934788cd02ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148132 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#76741} Refs: v8/v8@9a60704 PR-URL: nodejs#40046Fixes: nodejs#40030 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>

gengjiawen requested a review from targos September 9, 2021 06:40

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Sep 9, 2021

This comment has been minimized.
Sign in to view

gengjiawen added request-ci Add this label to start a Jenkins CI on a PR. fast-track PRs that do not need to wait for 48 hours to land. labels Sep 9, 2021

gengjiawen mentioned this pull request Sep 9, 2021
Check failed: !holder_map.has_named_interceptor(). when running jest#40030
Closed

targos mentioned this pull request Sep 9, 2021
deps: V8: cherry-pick 9a607043cb31 #40047
Closed

targos approved these changes Sep 9, 2021
View reviewed changes

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 9, 2021

rvsia added a commit to rvsia/sources-ui that referenced this pull request Sep 9, 2021
Limit node version to 16.8
81e8132
- until nodejs/node#40046 is merged

rvsia mentioned this pull request Sep 9, 2021
Unlock node 16 version when a fix is released RedHatInsights/sources-ui#748
Closed

gengjiawen added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 9, 2021

github-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 9, 2021

github-actionsBot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 9, 2021

richardlau approved these changes Sep 9, 2021
View reviewed changes

richardlau added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Sep 9, 2021

github-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 9, 2021

github-actionsBot closed this Sep 9, 2021

gengjiawen deleted the patch_v8 branch September 9, 2021 11:52

richardlau mentioned this pull request Sep 10, 2021
v16.9.1 proposal #40069
Merged

sxzz mentioned this pull request Sep 11, 2021
ci(project): upgrade to latest nodejs element-plus/element-plus#3351
Merged
3 tasks

This was referenced Sep 14, 2021
CI Reliability 2021-09-14 nodejs/reliability#58
Open
CI Reliability 2021-09-15 nodejs/reliability#59
Open
CI Reliability 2021-09-16 nodejs/reliability#60
Open
CI Reliability 2021-09-17 nodejs/reliability#61
Open

danielleadams mentioned this pull request Oct 4, 2021
v16.11.0 release proposal #40319
Merged

Navigation Menu

Uh oh!

Uh oh!

deps: V8: cherry-pick 9a607043cb31 - #40046

deps: V8: cherry-pick 9a607043cb31#40046
gengjiawen wants to merge 1 commit into
nodejs:masterfrom
gengjiawen:patch_v8

gengjiawen commented Sep 9, 2021

Uh oh!

This comment has been minimized.

github-actionsBot commented Sep 9, 2021

Uh oh!

targos commented Sep 9, 2021•
edited
Loading

Uh oh!

nodejs-github-bot commented Sep 9, 2021•
edited by targos
Loading

Uh oh!

nodejs-github-bot commented Sep 9, 2021•
edited by targos
Loading

Uh oh!

github-actionsBot commented Sep 9, 2021

Uh oh!

github-actionsBot commented Sep 9, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

gengjiawen commented Sep 9, 2021

Uh oh!

This comment has been minimized.

github-actionsBot commented Sep 9, 2021

Uh oh!

targos commented Sep 9, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Sep 9, 2021• edited by targos Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Sep 9, 2021• edited by targos Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Sep 9, 2021

Uh oh!

github-actionsBot commented Sep 9, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

targos commented Sep 9, 2021•
edited
Loading

nodejs-github-bot commented Sep 9, 2021•
edited by targos
Loading

nodejs-github-bot commented Sep 9, 2021•
edited by targos
Loading