Skip to content

doc: clarify that ObjectWrap requires manual cleanup on shutdown - #40074

Closed
Flarna wants to merge 2 commits into
nodejs:masterfrom
Flarna:doc-objectwrap
Closed

doc: clarify that ObjectWrap requires manual cleanup on shutdown#40074
Flarna wants to merge 2 commits into
nodejs:masterfrom
Flarna:doc-objectwrap

Conversation

@Flarna

@FlarnaFlarna commented Sep 10, 2021•
edited
Loading

Copy link
Copy Markdown
Member

Clarify that ObjectWrap instances are not destroyed on process or worker shutdown and require manual destruction to avoid resource leaks.

fixes: #38816

@nodejs-github-botnodejs-github-bot added addons Issues and PRs related to native addons. doc Issues and PRs related to the documentations. labels Sep 10, 2021
@FlarnaFlarna changed the title doc: ObjectWrap requires manual cleanup on shutdowndoc: clarify that ObjectWrap requires manual cleanup on shutdownSep 10, 2021
@Flarna
doc: clarify that ObjectWrap requires manual cleanup on shutdown
3146ba1
Clarify that ObjectWrap instances are not destroyed on process or
worker shutdown and require manual destruction to avoid resource
leaks.
mscdex
mscdex reviewed Sep 11, 2021
View reviewed changes
Comment threaddoc/api/addons.md Outdated
@FlarnaFlarna added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 11, 2021
mhdawson
mhdawson reviewed Sep 14, 2021
View reviewed changes
Comment threaddoc/api/addons.md
@FlarnaFlarna added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 15, 2021
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 15, 2021
@github-actions

github-actionsBot commented Sep 15, 2021

Copy link
Copy Markdown
Contributor

Landed in 8468bdb...7b4e6d4

nodejs-github-bot pushed a commit that referenced this pull request Sep 15, 2021
@Flarna@nodejs-github-bot
doc: clarify that ObjectWrap requires manual cleanup on shutdown
7b4e6d4
Clarify that ObjectWrap instances are not destroyed on process or
worker shutdown and require manual destruction to avoid resource
leaks.
PR-URL: #40074Fixes: #38816
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Flarna
Flarna deleted the doc-objectwrap branch September 15, 2021 15:08
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@Flarna@BethGriggs
doc: clarify that ObjectWrap requires manual cleanup on shutdown
16d903e
Clarify that ObjectWrap instances are not destroyed on process or
worker shutdown and require manual destruction to avoid resource
leaks.
PR-URL: #40074Fixes: #38816
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@Flarna@BethGriggs
doc: clarify that ObjectWrap requires manual cleanup on shutdown
81cb14b
Clarify that ObjectWrap instances are not destroyed on process or
worker shutdown and require manual destruction to avoid resource
leaks.
PR-URL: #40074Fixes: #38816
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Sep 21, 2021
Merged
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
+2 more reviewers
@mscdexmscdexmscdex left review comments
@mhdawsonmhdawsonmhdawson left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

addonsIssues and PRs related to native addons.author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

memleak using worker and objects wrapping c++ instances

6 participants

@Flarna@mscdex@jasnell@lpinca@mhdawson@nodejs-github-bot