Uh oh!
There was an error while loading. Please reload this page.
test: fix test-domain-with-abort-on-uncaught-exception.js on AIX - #4008
test: fix test-domain-with-abort-on-uncaught-exception.js on AIX#4008dnakamura wants to merge 1 commit into
Conversation
Add SIGTRAP as an expected signal when running on AIX. Port of f45c315 for v0.12
cjihrig
commented
Nov 24, 2015
LGTM if the CI is happy |
mhdawson
commented
Nov 24, 2015
@dnakamura, I think the original issue was seen on platforms other than AIX and was fixed so that it resolved those cases as well. Is the test in 0.12.X such that the fix was only needed for AIX ? Otherwise we should probably fix in a way similar to the original where it applies across platforms |
dnakamura
commented
Nov 25, 2015
Yeah, however the style of the test in this case is aimed more on a case by case basis. Not entirely sure on how to implement while keeping with the style of the test |
mhdawson
commented
Nov 25, 2015
Probably worth looking at the original issue to see what other platforms needed the same fix then at least we can include them in the if with AIX |
dnakamura
commented
Nov 25, 2015
Actually if those platforms indicate the signal in the return code, it should be simple |
mhdawson
commented
Nov 30, 2015
Ok, good to hear. I assume you'll update the patch to cover them |
mhdawson
commented
Dec 18, 2015
Devin do you have an idea when you'll have the update covering the other platforms ? |
c7a7253 to
fcc6479Comparemhdawson
commented
Feb 22, 2016
@dnakamura just wondering if you'll get to this soon |
jasnell
commented
Apr 12, 2016
@dnakamura ... ping |
rvagg
commented
May 5, 2016
ping, what's the status of this? we'll be at the end of v0.12 soon! |
mhdawson
commented
May 9, 2016
Going to ask @iwuzhere if he can take this one over |
I'd agree with @iwuzhere I think this can just be closed. I'll close if anybody disagrees please re-open. |
Add SIGTRAP as an expected signal when running on AIX. To fix failing test. see #3239
backport of f45c315 for v0.12