Uh oh!
There was an error while loading. Please reload this page.
meta: update AUTHORS - #40087
Closed
nodejs-github-bot wants to merge 1 commit into
Closed
Conversation
aduh95
reviewed
Sep 12, 2021
aduh95
left a comment
Contributor
There was a problem hiding this comment.
There seems to be two entries that do not points to real user information, should we remove those?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Trottforce-pushed
the
actions/authors-update
branch
from
September 12, 2021 23:40
f42bbe9 to
eb0d1c5CompareTrott
approved these changes
Sep 12, 2021
targos
approved these changes
Sep 13, 2021
aduh95
approved these changes
Sep 13, 2021
jasnell
approved these changes
Sep 13, 2021
tniessen
approved these changes
Sep 13, 2021
lpinca
approved these changes
Sep 13, 2021
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/40087 ✔ Done loading data for nodejs/node/pull/40087 ----------------------------------- PR info ------------------------------------ Title meta: update AUTHORS (#40087) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/authors-update -> nodejs:master Labels meta, author ready Commits 1 - meta: update AUTHORS Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/40087 Reviewed-By: Rich Trott Reviewed-By: Michaël Zasso Reviewed-By: Antoine du Hamel Reviewed-By: James M Snell Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40087 Reviewed-By: Rich Trott Reviewed-By: Michaël Zasso Reviewed-By: Antoine du Hamel Reviewed-By: James M Snell Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 12 Sep 2021 00:13:57 GMT ✔ Approvals: 6 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/40087#pullrequestreview-752227983 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/40087#pullrequestreview-752380264 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/40087#pullrequestreview-752410279 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/40087#pullrequestreview-752781492 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/40087#pullrequestreview-753027081 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/40087#pullrequestreview-753099880 ✖ GitHub CI is still running ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1232170175 |
PR-URL: #40087 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trottforce-pushed
the
actions/authors-update
branch
from
September 14, 2021 03:58
eb0d1c5 to
fa7c477CompareTrott
commented
Sep 14, 2021
Member
Landed in fa7c477 |
BethGriggs pushed a commit
that referenced
this pull request
Sep 21, 2021
PR-URL: #40087 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs pushed a commit
that referenced
this pull request
Sep 21, 2021
PR-URL: #40087 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If this PR exists, there's presumably new additions to the AUTHORS file. This is an automatically generated PR by the
authors.ymlGitHub Action, which runstools/update-authors.jsand submits a new PR or updates an existing PR.Please note that there might be duplicate entries. If there are, please remove them and add the duplicate emails to .mailmap directly to this PR.