Skip to content

deps: patch V8 to 9.3.345.19 - #40108

Closed
targos wants to merge 1 commit into
nodejs:masterfrom
targos:v8-9.3.345.19
Closed

deps: patch V8 to 9.3.345.19#40108
targos wants to merge 1 commit into
nodejs:masterfrom
targos:v8-9.3.345.19

Conversation

@targos

Copy link
Copy Markdown
Member

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Sep 14, 2021
@nodejs-github-bot

nodejs-github-bot commented Sep 14, 2021

Copy link
Copy Markdown
Collaborator

@jasnelljasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but it would definitely be helpful to include a short description of what is fixed by this in the PR.

@targos

Copy link
Copy Markdown
MemberAuthor

@jasnell if you click on the "Refs" link, you'll have the list of commits included with their descriptions.

@targos

Copy link
Copy Markdown
MemberAuthor

The actual bug that is fixed is under embargo, so I don't know what it is.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@targostargos added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 15, 2021
@VoltrexKeyvaVoltrexKeyva removed the needs-ci PRs that need a full CI run. label Sep 16, 2021
@targostargos added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 16, 2021
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 16, 2021
@github-actions

Copy link
Copy Markdown
Contributor

Landed in 1f8ed09...d23079d

nodejs-github-bot pushed a commit that referenced this pull request Sep 16, 2021
Refs: v8/v8@9.3.345.16...9.3.345.19
PR-URL: #40108
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
Refs: v8/v8@9.3.345.16...9.3.345.19
PR-URL: #40108
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
Refs: v8/v8@9.3.345.16...9.3.345.19
PR-URL: #40108
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Sep 21, 2021
1 task
@targos
targos deleted the v8-9.3.345.19 branch April 5, 2024 09:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@targos@nodejs-github-bot@jasnell@cjihrig@richardlau@VoltrexKeyva