Skip to content

build: optimize linux test workflow - #40118

Closed
willin wants to merge 1 commit into
nodejs:mainfrom
wshow:ci-patch-1
Closed

build: optimize linux test workflow#40118
willin wants to merge 1 commit into
nodejs:mainfrom
wshow:ci-patch-1

Conversation

@willin

@willinwillin commented Sep 15, 2021

Copy link
Copy Markdown

add ignored paths. which is from macos and asan

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Sep 15, 2021
@willinwillin changed the title ci: optimize linux test workflowbuild: optimize linux test workflowSep 15, 2021
Mesteery
Mesteery reviewed Sep 15, 2021
View reviewed changes
Comment thread.github/workflows/test-linux.yml
on:
pull_request:
types: [opened, synchronize, reopened, ready_for_review]
paths-ignore:

@MesteeryMesteerySep 15, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to run at least one build for doc changes -- at least one test checks for consistency between documentation and run time (hence needing a built node binary) behaviour:

#39871 (comment)

aduh95
aduh95 requested changes Sep 15, 2021
View reviewed changes

@aduh95aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending the PR. As the other comment says, I don't think we should disable the test-linux workflow as we still want to have those tests run at least once, and it's the build job that takes the least time to complete.

@bjohansebasbjohansebas added the stalled Issues and PRs that are stalled. label Nov 9, 2025
@github-actions

github-actionsBot commented Nov 9, 2025

Copy link
Copy Markdown
Contributor

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

@github-actions

github-actionsBot commented Dec 10, 2025

Copy link
Copy Markdown
Contributor

Closing this because it has stalled. Feel free to reopen if this issue/PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95aduh95aduh95 requested changes
+1 more reviewer
@MesteeryMesteeryMesteery left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

metaIssues and PRs related to the general management of the project.stalledIssues and PRs that are stalled.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@willin@aduh95@Mesteery@nodejs-github-bot@bjohansebas