Skip to content

crypto: fix webcrypto Curve25519 and Curve448 spki/pkcs8 imports - #40131

Closed
panva wants to merge 2 commits into
nodejs:masterfrom
panva:fix-ed-der-import
Closed

crypto: fix webcrypto Curve25519 and Curve448 spki/pkcs8 imports#40131
panva wants to merge 2 commits into
nodejs:masterfrom
panva:fix-ed-der-import

Conversation

@panva

@panvapanva commented Sep 16, 2021

Copy link
Copy Markdown
Member

Fixes the following webcrypto key algorithm' SPKI and PKCS8 imports

{ name: 'ECDH', namedCurve: 'NODE-X25519' }
{ name: 'ECDH', namedCurve: 'NODE-X448' }
{ name: 'NODE-ED25519', namedCurve: 'NODE-ED25519' }
{ name: 'NODE-ED448', namedCurve: 'NODE-ED448' }

@panvapanva added crypto Issues and PRs related to the crypto subsystem. webcrypto labels Sep 16, 2021
@panva
panva requested a review from jasnellSeptember 16, 2021 20:16
@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 16, 2021
@panva
panva requested a review from jasnellSeptember 16, 2021 20:18
@panvapanva added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Sep 16, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 16, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@panva

panva commented Sep 16, 2021

Copy link
Copy Markdown
MemberAuthor

cc @nodejs/crypto

@github-actionsgithub-actionsBot mentioned this pull request Sep 17, 2021
Open
18 tasks
tniessen
tniessen reviewed Sep 17, 2021
View reviewed changes
Comment threadtest/parallel/test-webcrypto-ed25519-ed448.js
@panvapanva added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 17, 2021
@panva
panva requested a review from tniessenSeptember 17, 2021 15:40
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 17, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Sep 17, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39985/

This was referenced Sep 18, 2021
Open
Open
Open
panva added a commit that referenced this pull request Sep 20, 2021
@panva
crypto: fix webcrypto ed(25519|448) spki/pkcs8 import
453bb6b
PR-URL: #40131
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@panva

panva commented Sep 20, 2021

Copy link
Copy Markdown
MemberAuthor

Landed in 453bb6b

@panvapanva closed this Sep 20, 2021
@panva
panva deleted the fix-ed-der-import branch September 20, 2021 09:38
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@panva@BethGriggs
crypto: fix webcrypto ed(25519|448) spki/pkcs8 import
e52867c
PR-URL: #40131
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@panva@BethGriggs
crypto: fix webcrypto ed(25519|448) spki/pkcs8 import
f0dec58
PR-URL: #40131
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@BethGriggsBethGriggs mentioned this pull request Sep 21, 2021
Merged
1 task
This was referenced Sep 22, 2021
Open
Open
Open
Open
Open
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tniessentniessentniessen approved these changes
@jasnelljasnellAwaiting requested review from jasnell

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.cryptoIssues and PRs related to the crypto subsystem.webcrypto

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@panva@nodejs-github-bot@jasnell@tniessen