Uh oh!
There was an error while loading. Please reload this page.
tools,doc: fix misrendering of consecutive JS blocks - #40146
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Our markdown-to-html tool was assuming that any consecutive JS blocks were ESM vs CJS alternatives, but that is not always the case, resulting in both a confusing interface and invalid HTML.
Trott
commented
Sep 18, 2021
MemberAuthor
There are three examples of this in the docs. Here is how a part of packages.html should be rendering (and how it renders with this change):
Here's how it looks currently:
The current situation results in a |
nodejs-github-bot
commented
Sep 18, 2021
Collaborator
targos
approved these changes
Sep 18, 2021
tniessen
approved these changes
Sep 18, 2021
aduh95
commented
Sep 18, 2021
Contributor
Weird, I thought I had taken this into consideration with line 227: Line 227 in 206c8bf Maybe line 227 can be removed if it's actually not useful. |
Trott
commented
Sep 18, 2021
MemberAuthor
I tried removing it but doing so ends up in garbled code examples elsewhere in the docs, so it seems like both statements handle different edge cases. |
aduh95
approved these changes
Sep 19, 2021
Contributor
Fast-track has been requested by @targos. Please 👍 to approve. |
Contributor
Landed in 0bafe6d...b0d5eec |
nodejs-github-bot pushed a commit
that referenced
this pull request
Sep 19, 2021
Our markdown-to-html tool was assuming that any consecutive JS blocks were ESM vs CJS alternatives, but that is not always the case, resulting in both a confusing interface and invalid HTML. PR-URL: #40146 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
BethGriggs pushed a commit
that referenced
this pull request
Sep 21, 2021
Our markdown-to-html tool was assuming that any consecutive JS blocks were ESM vs CJS alternatives, but that is not always the case, resulting in both a confusing interface and invalid HTML. PR-URL: #40146 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
BethGriggs pushed a commit
that referenced
this pull request
Sep 21, 2021
Our markdown-to-html tool was assuming that any consecutive JS blocks were ESM vs CJS alternatives, but that is not always the case, resulting in both a confusing interface and invalid HTML. PR-URL: #40146 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our markdown-to-html tool was assuming that any consecutive JS blocks
were ESM vs CJS alternatives, but that is not always the case, resulting
in both a confusing interface and invalid HTML.