Skip to content

meta: update AUTHORS - #40148

Merged
Trott merged 1 commit into
masterfrom
actions/authors-update
Sep 21, 2021
Merged

meta: update AUTHORS#40148
Trott merged 1 commit into
masterfrom
actions/authors-update

Conversation

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

If this PR exists, there's presumably new additions to the AUTHORS file. This is an automatically generated PR by the authors.yml GitHub Action, which runs tools/update-authors.js and submits a new PR or updates an existing PR.

Please note that there might be duplicate entries. If there are, please remove them and add the duplicate emails to .mailmap directly to this PR.

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Sep 19, 2021

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TrottTrott added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 21, 2021
@github-actionsgithub-actionsBot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 21, 2021
@github-actions

Copy link
Copy Markdown
Contributor
Commit Queue failed
- Loading data for nodejs/node/pull/40148
✔ Done loading data for nodejs/node/pull/40148
----------------------------------- PR info ------------------------------------
Title meta: update AUTHORS (#40148)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch nodejs-github-bot:actions/authors-update -> nodejs:master
Labels meta
Commits 1
- meta: update AUTHORS
Committers 1
- Node.js GitHub Bot PR-URL: https://github.com/nodejs/node/pull/40148
Reviewed-By: Rich Trott Reviewed-By: Michaël Zasso Reviewed-By: James M Snell Reviewed-By: Michael Dawson ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/40148
Reviewed-By: Rich Trott Reviewed-By: Michaël Zasso Reviewed-By: James M Snell Reviewed-By: Michael Dawson --------------------------------------------------------------------------------
ℹ This PR was created on Sun, 19 Sep 2021 00:13:30 GMT
✔ Approvals: 4
✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/40148#pullrequestreview-758160452
✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/40148#pullrequestreview-758162439
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/40148#pullrequestreview-758693926
✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/40148#pullrequestreview-758984059
✖ GitHub CI is still running
ℹ Green GitHub Actions CI is sufficient
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1257650399

PR-URL: #40148
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@Trott
Trottforce-pushed the actions/authors-update branch from 11424b6 to d05cca9CompareSeptember 21, 2021 12:55
@Trott
Trott merged commit d05cca9 into masterSep 21, 2021
@Trott

Copy link
Copy Markdown
Member

Landed in d05cca9

@Trott
Trott deleted the actions/authors-update branch September 21, 2021 12:56
@nodejsnodejs deleted a comment Sep 21, 2021
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
PR-URL: #40148
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
PR-URL: #40148
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@BethGriggsBethGriggs mentioned this pull request Sep 21, 2021
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue-failedAn error occurred while landing this pull request using GitHub Actions.metaIssues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@nodejs-github-bot@Trott@jasnell@targos@mhdawson