Uh oh!
There was an error while loading. Please reload this page.
doc: add blank line between comments - #40160
Conversation
aduh95
left a comment
There was a problem hiding this comment.
Could we instead tweak remark settings to allow the both with and without blank lines? I have a slight preference for block of comments when they are related (comments to disable lint rules make more sense as one block than as three or more different blocks imho), but no strong feelings.
Trott
commented
Sep 20, 2021
My intention is to use it both as a linter and a formatter. If we use it as a formatter (like prettier), we have to choose one or the other. (Or at least I'd think so.) However, in the case of lint comments, it's easy enough to consolidate them into a single comment, so that's what I'll do here. |
Upcoming remark-based formatting/linting will add a blank line between comments in markdown. This is in preparation for that change. PR-URL: nodejs#40160 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trott
commented
Sep 22, 2021
Landed in 0991dfc |
Upcoming remark-based formatting/linting will add a blank line between comments in markdown. This is in preparation for that change. PR-URL: #40160 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Upcoming remark-based formatting/linting will add a blank line between
comments in markdown. This is in preparation for that change.