Skip to content

doc: fix typo error - #40187

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
xuchaobei:patch-1
Sep 24, 2021
Merged

doc: fix typo error#40187
aduh95 merged 1 commit into
nodejs:masterfrom
xuchaobei:patch-1

Conversation

@xuchaobei

@xuchaobeixuchaobei commented Sep 23, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@nodejs-github-botnodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations. labels Sep 23, 2021
Ayase-252
Ayase-252 approved these changes Sep 23, 2021
View reviewed changes

@Ayase-252Ayase-252 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks

@xuchaobeixuchaobei changed the title fix typo errordoc: fix typo errorSep 23, 2021
@jasnelljasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 23, 2021
@github-actions

github-actionsBot commented Sep 23, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @jasnell. Please 👍 to approve.

@jasnelljasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 23, 2021
@aduh95aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 23, 2021
@xuchaobei@aduh95
doc: fix typo in async_hooks.md
5f3c1b6
PR-URL: nodejs#40187
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95

aduh95 commented Sep 24, 2021

Copy link
Copy Markdown
Contributor

Landed in 5f3c1b6

@aduh95
aduh95 merged commit 5f3c1b6 into nodejs:masterSep 24, 2021
targos pushed a commit that referenced this pull request Oct 4, 2021
@xuchaobei@targos
doc: fix typo in async_hooks.md
59db829
PR-URL: #40187
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Oct 4, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@tniessentniessentniessen approved these changes
@Ayase-252Ayase-252Ayase-252 approved these changes
@LxxyxLxxyxLxxyx approved these changes

Assignees

No one assigned

Labels

async_hooksIssues and PRs related to the async hooks subsystem.author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@xuchaobei@aduh95@jasnell@lpinca@cjihrig@tniessen@Ayase-252@Lxxyx@nodejs-github-bot