Skip to content

http: use 0 as default for requests limit - #40192

Closed
fatal10110 wants to merge 2 commits into
nodejs:masterfrom
fatal10110:default_max_requests
Closed

http: use 0 as default for requests limit#40192
fatal10110 wants to merge 2 commits into
nodejs:masterfrom
fatal10110:default_max_requests

Conversation

@fatal10110

@fatal10110fatal10110 commented Sep 23, 2021

Copy link
Copy Markdown
Contributor

closes#40190

@nodejs-github-botnodejs-github-bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Sep 23, 2021
mcollina
mcollina reviewed Sep 24, 2021
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test?

@fatal10110

fatal10110 commented Sep 24, 2021

Copy link
Copy Markdown
ContributorAuthor

I think default value is tested here already
https://github.com/nodejs/node/blob/master/test/parallel/test-http-keep-alive.js

I can add a test that tests a "null" value

@fatal10110

fatal10110 commented Sep 24, 2021

Copy link
Copy Markdown
ContributorAuthor

I think default value is tested here already

Nvm, I was wrong, im not sure what is tested there, I will write my own test

mcollina
mcollina approved these changes Sep 24, 2021
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot

nodejs-github-bot commented Sep 24, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40055/

@targostargos added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 26, 2021
XadillaX
XadillaX approved these changes Sep 26, 2021
View reviewed changes

@XadillaXXadillaX left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major or patch?

@mcollina

mcollina commented Sep 27, 2021

Copy link
Copy Markdown
Member

I would go with patch, this a bug/oversight.

mcollina pushed a commit that referenced this pull request Sep 27, 2021
@fatal10110@mcollina
http: use 0 as default for requests limit
44b173e
PR-URL: #40192
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
@mcollina

mcollina commented Sep 27, 2021

Copy link
Copy Markdown
Member

Landed in 44b173e

@fatal10110fatal10110 mentioned this pull request Sep 28, 2021
Closed
targos pushed a commit that referenced this pull request Oct 4, 2021
@fatal10110@targos
http: use 0 as default for requests limit
22725f5
PR-URL: #40192
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
@danielleadamsdanielleadams mentioned this pull request Oct 4, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@jasnelljasnelljasnell approved these changes
+1 more reviewer
@XadillaXXadillaXXadillaX approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.httpIssues or PRs related to the http subsystem.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Lack of consistency in maxRequestPerSocket

6 participants

@fatal10110@nodejs-github-bot@mcollina@jasnell@XadillaX@targos