Skip to content

doc: mark readline promise implementation as experimental - #40211

Closed
aduh95 wants to merge 1 commit into
nodejs:masterfrom
aduh95:experimental-readline-promise-api
Closed

doc: mark readline promise implementation as experimental#40211
aduh95 wants to merge 1 commit into
nodejs:masterfrom
aduh95:experimental-readline-promise-api

Conversation

@aduh95

@aduh95aduh95 commented Sep 24, 2021

Copy link
Copy Markdown
Contributor

Are we sure about the API? Maybe we should make it experimental in case we need to make changes after it's released?

Originally posted by @targos in #37947 (comment)

@aduh95aduh95 added readline Issues and PRs related to the built-in readline module. experimental Issues and PRs related to experimental features. dont-land-on-v12.x labels Sep 24, 2021
@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 24, 2021
@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 25, 2021
@targostargos added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 27, 2021
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 27, 2021
@github-actions

github-actionsBot commented Sep 27, 2021

Copy link
Copy Markdown
Contributor

Landed in 8037d17...78962d1

nodejs-github-bot pushed a commit that referenced this pull request Sep 27, 2021
@aduh95@nodejs-github-bot
doc: mark readline promise implementation as experimental
78962d1
Refs: #37947 (comment)
PR-URL: #40211
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@aduh95
aduh95 deleted the experimental-readline-promise-api branch September 27, 2021 21:54
@BethGriggsBethGriggs mentioned this pull request Oct 14, 2021
Merged
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@targostargostargos approved these changes
@cjihrigcjihrigcjihrig approved these changes
@LxxyxLxxyxLxxyx approved these changes
@RaisinTenRaisinTenRaisinTen approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.experimentalIssues and PRs related to experimental features.readlineIssues and PRs related to the built-in readline module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@aduh95@jasnell@targos@cjihrig@Lxxyx@RaisinTen@nodejs-github-bot