Skip to content

doc: fix typo in packages.md - #40230

Closed
warlock1996 wants to merge 1 commit into
nodejs:masterfrom
warlock1996:patch-1
Closed

doc: fix typo in packages.md#40230
warlock1996 wants to merge 1 commit into
nodejs:masterfrom
warlock1996:patch-1

Conversation

@warlock1996

@warlock1996warlock1996 commented Sep 27, 2021•
edited by aduh95
Loading

Copy link
Copy Markdown
Contributor

remove typo in statement, it should say condition

Fixes: #40228

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 27, 2021
@thunder-coding

thunder-coding commented Sep 27, 2021

Copy link
Copy Markdown
Contributor

Consider linking the issue #40228 (i.e. add "Fixes #40228" at the end of PR comment)

For more information about linking issue see https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

@lpincalpinca added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 27, 2021
@github-actions

github-actionsBot commented Sep 27, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @lpinca. Please 👍 to approve.

@aduh95aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 27, 2021
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 27, 2021
@github-actions

github-actionsBot commented Sep 27, 2021

Copy link
Copy Markdown
Contributor

Landed in fbeeddd...fda1402

nodejs-github-bot pushed a commit that referenced this pull request Sep 27, 2021
@warlock1996@nodejs-github-bot
doc: fix typo in packages.md
fda1402
PR-URL: #40230Fixes: #40228
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95

aduh95 commented Sep 27, 2021

Copy link
Copy Markdown
Contributor

Thanks a lot for the contribution!

@warlock1996

warlock1996 commented Sep 28, 2021

Copy link
Copy Markdown
ContributorAuthor

pleasure, feeling great to contribute to!

targos pushed a commit that referenced this pull request Oct 4, 2021
@warlock1996@targos
doc: fix typo in packages.md
614a7c2
PR-URL: #40230Fixes: #40228
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Oct 4, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@tniessentniessentniessen approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Node JS Docs Typo

6 participants

@warlock1996@thunder-coding@aduh95@lpinca@tniessen@nodejs-github-bot