Skip to content

lib: make structuredClone spec compliant - #40251

Closed
VoltrexKeyva wants to merge 1 commit into
nodejs:masterfrom
VoltrexKeyva:fix-structuredclone
Closed

lib: make structuredClone spec compliant#40251
VoltrexKeyva wants to merge 1 commit into
nodejs:masterfrom
VoltrexKeyva:fix-structuredclone

Conversation

@VoltrexKeyva

@VoltrexKeyvaVoltrexKeyva commented Sep 29, 2021

Copy link
Copy Markdown
Contributor

Fixes: #40246

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 29, 2021
@targos

targos commented Sep 29, 2021

Copy link
Copy Markdown
Member

It would be nice to have a WPT for this.

@targos

targos commented Sep 29, 2021

Copy link
Copy Markdown
Member

BTW, I'm not sure we should throw an error, but instead just grab transfer from the passed object and create a new options object with it.

@VoltrexKeyva

VoltrexKeyva commented Sep 29, 2021

Copy link
Copy Markdown
ContributorAuthor

BTW, I'm not sure we should throw an error, but instead just grab transfer from the passed object and create a new options object with it.

We mostly just throw an error if the passed value is not spec complaint in most cases, throwing an error here would be nice for keeping consistency unless there's a special case where we have to avoid throwing an error.

@targos

targos commented Sep 29, 2021

Copy link
Copy Markdown
Member

What's important here is not consistency, but spec compliance. The spec just asks to pass options["transfer"]. Maybe I'm wrong, but I understand that it should not be an error to do this:

constoptions=[];options.transfer=[toTransfer];structuredClone({},options);

aduh95
aduh95 reviewed Sep 29, 2021
View reviewed changes
Comment threadlib/internal/structured_clone.js Outdated
@targos

targos commented Sep 29, 2021

Copy link
Copy Markdown
Member

Do we have a WHATWG spec specialist that we could ping to take a look?

@aduh95

aduh95 commented Sep 29, 2021

Copy link
Copy Markdown
Contributor

Maybe @surma would be available to review this, since they are the one who proposed this API to WHATWG.

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 3, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 3, 2021
@nodejs-github-bot

nodejs-github-bot commented Oct 3, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40142/

@nodejs-github-bot

nodejs-github-bot commented Oct 3, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40144/

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 3, 2021
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 3, 2021
@github-actions

github-actionsBot commented Oct 3, 2021

Copy link
Copy Markdown
Contributor

Landed in 6199441...3d11baf

nodejs-github-bot pushed a commit that referenced this pull request Oct 3, 2021
@VoltrexKeyva@nodejs-github-bot
lib: make structuredClone spec compliant
3d11baf
Fixes: #40246
PR-URL: #40251
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@VoltrexKeyva
VoltrexKeyva deleted the fix-structuredclone branch October 3, 2021 15:25
@github-actionsgithub-actionsBot mentioned this pull request Oct 4, 2021
Open
22 tasks
danielleadams pushed a commit that referenced this pull request Oct 4, 2021
@VoltrexKeyva@danielleadams
lib: make structuredClone spec compliant
3fbc172
Fixes: #40246
PR-URL: #40251
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Oct 4, 2021
@VoltrexKeyva@danielleadams
lib: make structuredClone spec compliant
57491ca
Fixes: #40246
PR-URL: #40251
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Oct 4, 2021
Merged
@github-actionsgithub-actionsBot mentioned this pull request Oct 5, 2021
Open
21 tasks
danielleadams pushed a commit that referenced this pull request Oct 5, 2021
@VoltrexKeyva@danielleadams
lib: make structuredClone spec compliant
1ccecf4
Fixes: #40246
PR-URL: #40251
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This was referenced Oct 6, 2021
Open
Open
Open
Open
@BethGriggsBethGriggs mentioned this pull request Oct 14, 2021
Merged
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@benjamingrbenjamingrbenjamingr approved these changes
@targostargostargos approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Invalid globalThis.structuredClone interface

7 participants

@VoltrexKeyva@targos@aduh95@nodejs-github-bot@jasnell@benjamingr@danielleadams