Uh oh!
There was an error while loading. Please reload this page.
meta: update AUTHORS - #40289
Closed
nodejs-github-bot wants to merge 1 commit into
Closed
Conversation
Trott
approved these changes
Oct 3, 2021
Trott
left a comment
Member
There was a problem hiding this comment.
Checked for duplicates and none of these are duplicates. LGTM.
Contributor
Fast-track has been requested by @Trott. Please 👍 to approve. |
targos
approved these changes
Oct 3, 2021
Lxxyx
approved these changes
Oct 3, 2021
This comment has been minimized.
This comment has been minimized.
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/40289 ✔ Done loading data for nodejs/node/pull/40289 ----------------------------------- PR info ------------------------------------ Title meta: update AUTHORS (#40289) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/authors-update -> nodejs:master Labels meta, fast-track Commits 1 - meta: update AUTHORS Committers 1 - Node.js GitHub Bot PR-URL: https://github.com/nodejs/node/pull/40289 Reviewed-By: Rich Trott Reviewed-By: Michaël Zasso Reviewed-By: Zijian Liu ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40289 Reviewed-By: Rich Trott Reviewed-By: Michaël Zasso Reviewed-By: Zijian Liu -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 03 Oct 2021 00:14:51 GMT ✔ Approvals: 3 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/40289#pullrequestreview-769539360 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/40289#pullrequestreview-769554392 ✔ - Zijian Liu (@Lxxyx): https://github.com/nodejs/node/pull/40289#pullrequestreview-769561892 ℹ This PR is being fast-tracked ✖ GitHub CI is still running ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1300138966 |
Lxxyx pushed a commit
to Lxxyx/node
that referenced
this pull request
Oct 3, 2021
PR-URL: nodejs#40289 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Lxxyx
commented
Oct 3, 2021
Member
Landed in 5ae72b7 |
targos pushed a commit
that referenced
this pull request
Oct 4, 2021
PR-URL: #40289 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If this PR exists, there's presumably new additions to the AUTHORS file. This is an automatically generated PR by the
authors.ymlGitHub Action, which runstools/update-authors.jsand submits a new PR or updates an existing PR.Please note that there might be duplicate entries. If there are, please remove them and add the duplicate emails to .mailmap directly to this PR.