Uh oh!
There was an error while loading. Please reload this page.
doc: format markdown files in test directory - #40290
Merged
Merged
Conversation
targos
approved these changes
Oct 3, 2021
Lxxyx
approved these changes
Oct 3, 2021
watilde
approved these changes
Oct 3, 2021
tniessen
commented
Oct 3, 2021
Member
@Trott could this potentially be covered by linters so that we don't need to manually format it every once in a while? |
Trott
commented
Oct 3, 2021
MemberAuthor
Possibly. Right now, we can't autoformat because it would break the README.md format depended on by node-core-utils and possibly other things. (I had tried to get ahead of that but got too far ahead of it....) And there are a lot of these kinds of fixes in |
Contributor
Fast-track has been requested by @Trott. Please 👍 to approve. |
jasnell
approved these changes
Oct 3, 2021
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/40290 ✔ Done loading data for nodejs/node/pull/40290 ----------------------------------- PR info ------------------------------------ Title doc: format markdown files in test directory (#40290) Author Rich Trott (@Trott) Branch Trott:test-format -> nodejs:master Labels test, async_hooks, author ready Commits 1 - doc: format markdown files in test directory Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/40290 Reviewed-By: Michaël Zasso Reviewed-By: Zijian Liu Reviewed-By: Daijiro Wachi Reviewed-By: Tobias Nießen Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40290 Reviewed-By: Michaël Zasso Reviewed-By: Zijian Liu Reviewed-By: Daijiro Wachi Reviewed-By: Tobias Nießen Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 03 Oct 2021 01:48:26 GMT ✔ Approvals: 5 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/40290#pullrequestreview-769557341 ✔ - Zijian Liu (@Lxxyx): https://github.com/nodejs/node/pull/40290#pullrequestreview-769561820 ✔ - Daijiro Wachi (@watilde): https://github.com/nodejs/node/pull/40290#pullrequestreview-769564399 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/40290#pullrequestreview-769580958 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/40290#pullrequestreview-769596533 ✔ Last GitHub Actions successful ✖ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1306219419 |
Use `make format-md` to format markdown files in `test` directory. PR-URL: nodejs#40290 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Trott
commented
Oct 5, 2021
MemberAuthor
Landed in cbd61c9 |
danielleadams pushed a commit
that referenced
this pull request
Oct 5, 2021
Use `make format-md` to format markdown files in `test` directory. PR-URL: #40290 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
make format-mdto format markdown files intestdirectory.