Skip to content

doc,src: update crypto/README.md - #40332

Merged
Trott merged 1 commit into
nodejs:masterfrom
tniessen:src-crypto-readme-ecdh-ec
Oct 7, 2021
Merged

doc,src: update crypto/README.md#40332
Trott merged 1 commit into
nodejs:masterfrom
tniessen:src-crypto-readme-ecdh-ec

Conversation

@tniessen

Copy link
Copy Markdown
Member

This is due to #37048.

@Ayase-252Ayase-252 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Oct 6, 2021
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Ayase-252. Please 👍 to approve.

@TrottTrott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2021
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2021
@github-actions

Copy link
Copy Markdown
Contributor
Commit Queue failed
- Loading data for nodejs/node/pull/40332
✔ Done loading data for nodejs/node/pull/40332
----------------------------------- PR info ------------------------------------
Title doc,src: update crypto/README.md (#40332)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch tniessen:src-crypto-readme-ecdh-ec -> nodejs:master
Labels fast-track, author ready
Commits 1
- doc,src: update crypto/README.md
Committers 1
- GitHub PR-URL: https://github.com/nodejs/node/pull/40332
Reviewed-By: Luigi Pinca Reviewed-By: Filip Skokan Reviewed-By: Zijian Liu Reviewed-By: Qingyu Deng ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/40332
Reviewed-By: Luigi Pinca Reviewed-By: Filip Skokan Reviewed-By: Zijian Liu Reviewed-By: Qingyu Deng --------------------------------------------------------------------------------
ℹ This PR was created on Tue, 05 Oct 2021 14:07:49 GMT
✔ Approvals: 4
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/40332#pullrequestreview-771780799
✔ - Filip Skokan (@panva): https://github.com/nodejs/node/pull/40332#pullrequestreview-771868688
✔ - Zijian Liu (@Lxxyx): https://github.com/nodejs/node/pull/40332#pullrequestreview-772216560
✔ - Qingyu Deng (@Ayase-252): https://github.com/nodejs/node/pull/40332#pullrequestreview-773116029
ℹ This PR is being fast-tracked
✔ Last GitHub Actions successful
✖ No Jenkins CI runs detected
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1314590958

@github-actionsgithub-actionsBot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 7, 2021
Refs: nodejs#37048
PR-URL: nodejs#40332
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
@Trott
Trottforce-pushed the src-crypto-readme-ecdh-ec branch from d8517e4 to 055311aCompareOctober 7, 2021 04:16
@Trott

Trott commented Oct 7, 2021

Copy link
Copy Markdown
Member

Landed in 055311a

@Trott
Trott merged commit 055311a into nodejs:masterOct 7, 2021
danielleadams pushed a commit that referenced this pull request Oct 7, 2021
Refs: #37048
PR-URL: #40332
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
@tniessen
tniessen deleted the src-crypto-readme-ecdh-ec branch October 7, 2021 16:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-failedAn error occurred while landing this pull request using GitHub Actions.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@tniessen@Trott@panva@lpinca@Ayase-252@Lxxyx