Skip to content

meta: consolidate AUTHORS entries for ebickle - #40447

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:authors-eb
Closed

meta: consolidate AUTHORS entries for ebickle#40447
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:authors-eb

Conversation

@Trott

Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 13, 2021
@Trott

Trott commented Oct 13, 2021

Copy link
Copy Markdown
MemberAuthor

@ebickle This PR removes your users.noreply.github.com from the AUTHORS file in favor of your outlook.com email address. (Currently, there is an entry for each email address.) If you want to do it the other way around, please me know. Thanks!

@ebickle

ebickle commented Oct 14, 2021

Copy link
Copy Markdown
Contributor

Looks good to me, thank you!

@Trott If my noreply address isn't needed for correlating to commits, you're welcome to just leave the @outlook.com one if its preferable.

@MesteeryMesteery added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 14, 2021
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Mesteery. Please 👍 to approve.

@MesteeryMesteery added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 14, 2021
@TrottTrott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 15, 2021
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 15, 2021
@github-actions

Copy link
Copy Markdown
Contributor

Landed in a278117...881174e

nodejs-github-bot pushed a commit that referenced this pull request Oct 15, 2021
PR-URL: #40447
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott
Trott deleted the authors-eb branch October 15, 2021 13:23
@BethGriggsBethGriggs mentioned this pull request Oct 18, 2021
2 tasks
targos pushed a commit that referenced this pull request Nov 4, 2021
PR-URL: #40447
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Nov 26, 2021
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.metaIssues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@Trott@ebickle@lpinca@Lxxyx@nodejs-github-bot@Mesteery