Skip to content

deps: V8: cherry-pick 422dc378a1da - #40450

Closed
rayw000 wants to merge 1 commit into
nodejs:masterfrom
rayw000:cherry-pick-v8-422dc37
Closed

deps: V8: cherry-pick 422dc378a1da#40450
rayw000 wants to merge 1 commit into
nodejs:masterfrom
rayw000:cherry-pick-v8-422dc37

Conversation

@rayw000

@rayw000rayw000 commented Oct 14, 2021

Copy link
Copy Markdown
Contributor

Original commit message:

[deserialization] Remove unnecessarily limit on buffer size
1. Now there is no serializer/deserializer-specific buffer size limit.
2. Update AUTHORS
Ref: https://github.com/nodejs/node/issues/40059
Change-Id: Iad4c6d8f68a91ef21d3c404fb7945949e69ad9e2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3170411
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/main@{#77084}

Refs: v8/v8@422dc37

Related to: #40243
Fix: #40059

@rayw000
deps: V8: cherry-pick 422dc378a1da
0b9491c
Original commit message:
[deserialization] Remove unnecessarily limit on buffer size
1. Now there is no serializer/deserializer-specific buffer size limit.
2. Update AUTHORS
Ref: #40059
Change-Id: Iad4c6d8f68a91ef21d3c404fb7945949e69ad9e2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3170411
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/main@{#77084}
Refs: v8/v8@422dc37
@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Oct 14, 2021
@nodejs-github-bot

nodejs-github-bot commented Oct 14, 2021•
edited by targos
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40298/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4327/

@nodejs-github-bot

nodejs-github-bot commented Oct 14, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40305/

This was referenced Oct 15, 2021
Open
Open
Open
Open
Open
@rayw000

rayw000 commented Oct 19, 2021

Copy link
Copy Markdown
ContributorAuthor

Hi @targos@cjihrig

I can't tell how the four failing tests relate to this PR. Could you help me to make this PR landable? Thank you!

@targostargos added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2021
@targos

targos commented Oct 19, 2021

Copy link
Copy Markdown
Member

They don't. I requested a new CI run.

@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2021
@nodejs-github-bot

nodejs-github-bot commented Oct 19, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40361/

@nodejs-github-bot

nodejs-github-bot commented Oct 19, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40365/

This was referenced Oct 20, 2021
Open
Open
Open
Open
@rayw000

rayw000 commented Oct 23, 2021

Copy link
Copy Markdown
ContributorAuthor

Hi @targos

If you land this PR, please also land #40243 . They are all for issue #40059. Thanks.

targos pushed a commit that referenced this pull request Oct 23, 2021
@rayw000@targos
deps: V8: cherry-pick 422dc378a1da
c83f47f
Original commit message:
[deserialization] Remove unnecessarily limit on buffer size
1. Now there is no serializer/deserializer-specific buffer size limit.
2. Update AUTHORS
Ref: #40059
Change-Id: Iad4c6d8f68a91ef21d3c404fb7945949e69ad9e2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3170411
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/main@{#77084}
Refs: v8/v8@422dc37
PR-URL: #40450Fixes: #40059
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos

targos commented Oct 23, 2021

Copy link
Copy Markdown
Member

Landed in c83f47f

@targostargos closed this Oct 23, 2021
targos pushed a commit that referenced this pull request Oct 23, 2021
@rayw000@targos
deps: V8: cherry-pick 422dc378a1da
8d16f0d
Original commit message:
[deserialization] Remove unnecessarily limit on buffer size
1. Now there is no serializer/deserializer-specific buffer size limit.
2. Update AUTHORS
Ref: #40059
Change-Id: Iad4c6d8f68a91ef21d3c404fb7945949e69ad9e2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3170411
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/main@{#77084}
Refs: v8/v8@422dc37
PR-URL: #40450Fixes: #40059
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@rayw000rayw000 mentioned this pull request Oct 23, 2021
Closed
@rayw000
rayw000 deleted the cherry-pick-v8-422dc37 branch October 23, 2021 07:21
This was referenced Oct 24, 2021
Open
Open
@targostargos mentioned this pull request Nov 8, 2021
Merged
BethGriggs pushed a commit that referenced this pull request Nov 24, 2021
@rayw000@BethGriggs
deps: V8: cherry-pick 422dc378a1da
91c3cf5
Original commit message:
[deserialization] Remove unnecessarily limit on buffer size
1. Now there is no serializer/deserializer-specific buffer size limit.
2. Update AUTHORS
Ref: #40059
Change-Id: Iad4c6d8f68a91ef21d3c404fb7945949e69ad9e2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3170411
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/main@{#77084}
Refs: v8/v8@422dc37
PR-URL: #40450Fixes: #40059
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Nov 26, 2021
Merged
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targostargostargos approved these changes
@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.needs-ciPRs that need a full CI run.v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document (or fix?) v8.deserialize' 2gb limitation for input buffer

4 participants

@rayw000@nodejs-github-bot@targos@cjihrig