Skip to content

test: split test-crypto-dh.js - #40451

Closed
joyeecheung wants to merge 2 commits into
nodejs:masterfrom
joyeecheung:split-crypto-tests
Closed

test: split test-crypto-dh.js#40451
joyeecheung wants to merge 2 commits into
nodejs:masterfrom
joyeecheung:split-crypto-tests

Conversation

@joyeecheung

Copy link
Copy Markdown
Member

Split test-crypto-dh.js so that it is less likely to timeout on
less powerful bots.

Refs: nodejs/reliability#86

Split test-crypto-dh.js so that it is less likely to timeout on
less powerful bots.
@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 14, 2021
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@joyeecheung

Copy link
Copy Markdown
MemberAuthor

It doesn't seem possible to run stress tests on the raspberry pis, is there any other way to see it this make the test time out less?

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@MesteeryMesteery added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Oct 16, 2021
@Trott

Trott commented Oct 17, 2021

Copy link
Copy Markdown
Member

It doesn't seem possible to run stress tests on the raspberry pis, is there any other way to see it this make the test time out less?

These are separate jobs for stress tests on the Raspberry Pi devices. https://ci.nodejs.org/view/All/job/node-stress-single-test-pi1-binary/https://ci.nodejs.org/view/Stress/job/node-stress-single-test-pi1-fanned/ I honestly forget how to use them so I'm not sure if they still work or not.

@joyeecheung

Copy link
Copy Markdown
MemberAuthor

Landed in 5d0d611

joyeecheung added a commit that referenced this pull request Oct 19, 2021
Split test-crypto-dh.js so that it is less likely to timeout on
less powerful bots.
PR-URL: #40451
Refs: nodejs/reliability#86
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Oct 20, 2021
Split test-crypto-dh.js so that it is less likely to timeout on
less powerful bots.
PR-URL: #40451
Refs: nodejs/reliability#86
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targostargos mentioned this pull request Oct 20, 2021
targos pushed a commit that referenced this pull request Nov 4, 2021
Split test-crypto-dh.js so that it is less likely to timeout on
less powerful bots.
PR-URL: #40451
Refs: nodejs/reliability#86
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Nov 26, 2021
1 task
codebytere added a commit to electron/electron that referenced this pull request Oct 19, 2022
codebytere added a commit to electron/electron that referenced this pull request Oct 24, 2022
codebytere added a commit to electron/electron that referenced this pull request Nov 8, 2022
codebytere added a commit to electron/electron that referenced this pull request Nov 8, 2022
codebytere added a commit to electron/electron that referenced this pull request Nov 10, 2022
* chore: update to Node.js v18
* child_process: improve argument validation
nodejs/node#41305
* bootstrap: support configure-time user-land snapshot
nodejs/node#42466
* chore: update GN patch
* src: disambiguate terms used to refer to builtins and addons
nodejs/node#44135
* src: use a typed array internally for process._exiting
nodejs/node#43883
* chore: lib/internal/bootstrap -> lib/internal/process
* src: disambiguate terms used to refer to builtins and addons
nodejs/node#44135
* chore: remove redudant browserGlobals patch
* chore: update BoringSSL patch
* src: allow embedder-provided PageAllocator in NodePlatform
nodejs/node#38362
* chore: fixup Node.js crypto tests
- nodejs/node#44171
- nodejs/node#41600
* lib: add Promise methods to avoid-prototype-pollution lint rule
nodejs/node#43849
* deps: update V8 to 10.1
nodejs/node#42657
* src: add kNoBrowserGlobals flag for Environment
nodejs/node#40532
* chore: consolidate asar initialization patches
* deps: update V8 to 10.1
nodejs/node#42657
* deps: update V8 to 9.8
nodejs/node#41610
* src,crypto: remove AllocatedBuffers from crypto_spkac
nodejs/node#40752
* build: enable V8's shared read-only heap
nodejs/node#42809
* src: fix ssize_t error from nghttp2.h
nodejs/node#44393
* chore: fixup ESM patch
* chore: fixup patch indices
* src: merge NativeModuleEnv into NativeModuleLoader
nodejs/node#43824
* [API] Pass OOMDetails to OOMErrorCallback
https://chromium-review.googlesource.com/c/v8/v8/+/3647827
* src: iwyu in cleanup_queue.cc
* src: return Maybe from a couple of functions
nodejs/node#39603
* src: clean up embedder API
nodejs/node#35897
* src: refactor DH groups to delete crypto_groups.h
nodejs/node#43896
* deps,src: use SIMD for normal base64 encoding
nodejs/node#39775
* chore: remove deleted source file
* chore: update patches
* chore: remove deleted source file
* lib: add fetch
nodejs/node#41749
* chore: remove nonexistent node specs
* test: split report OOM tests
nodejs/node#44389
* src: trace fs async api
nodejs/node#44057
* http: trace http request / response
nodejs/node#44102
* test: split test-crypto-dh.js
nodejs/node#40451
* crypto: introduce X509Certificate API
nodejs/node#36804
* src: split property helpers from node::Environment
nodejs/node#44056
* nodejs/node#38905
bootstrap: implement run-time user-land snapshots via --build-snapshot and --snapshot-blob
* lib,src: implement WebAssembly Web API
nodejs/node#42701
* fixup! deps,src: use SIMD for normal base64 encoding
* fixup! src: refactor DH groups to delete crypto_groups.h
* chore: fixup base64 GN file
* fix: check that node::InitializeContext() returns true
* chore: delete _noBrowserGlobals usage
* chore: disable fetch in renderer procceses
* dns: default to verbatim=true in dns.lookup()
nodejs/node#39987
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
* chore: update to Node.js v18
* child_process: improve argument validation
nodejs/node#41305
* bootstrap: support configure-time user-land snapshot
nodejs/node#42466
* chore: update GN patch
* src: disambiguate terms used to refer to builtins and addons
nodejs/node#44135
* src: use a typed array internally for process._exiting
nodejs/node#43883
* chore: lib/internal/bootstrap -> lib/internal/process
* src: disambiguate terms used to refer to builtins and addons
nodejs/node#44135
* chore: remove redudant browserGlobals patch
* chore: update BoringSSL patch
* src: allow embedder-provided PageAllocator in NodePlatform
nodejs/node#38362
* chore: fixup Node.js crypto tests
- nodejs/node#44171
- nodejs/node#41600
* lib: add Promise methods to avoid-prototype-pollution lint rule
nodejs/node#43849
* deps: update V8 to 10.1
nodejs/node#42657
* src: add kNoBrowserGlobals flag for Environment
nodejs/node#40532
* chore: consolidate asar initialization patches
* deps: update V8 to 10.1
nodejs/node#42657
* deps: update V8 to 9.8
nodejs/node#41610
* src,crypto: remove AllocatedBuffers from crypto_spkac
nodejs/node#40752
* build: enable V8's shared read-only heap
nodejs/node#42809
* src: fix ssize_t error from nghttp2.h
nodejs/node#44393
* chore: fixup ESM patch
* chore: fixup patch indices
* src: merge NativeModuleEnv into NativeModuleLoader
nodejs/node#43824
* [API] Pass OOMDetails to OOMErrorCallback
https://chromium-review.googlesource.com/c/v8/v8/+/3647827
* src: iwyu in cleanup_queue.cc
* src: return Maybe from a couple of functions
nodejs/node#39603
* src: clean up embedder API
nodejs/node#35897
* src: refactor DH groups to delete crypto_groups.h
nodejs/node#43896
* deps,src: use SIMD for normal base64 encoding
nodejs/node#39775
* chore: remove deleted source file
* chore: update patches
* chore: remove deleted source file
* lib: add fetch
nodejs/node#41749
* chore: remove nonexistent node specs
* test: split report OOM tests
nodejs/node#44389
* src: trace fs async api
nodejs/node#44057
* http: trace http request / response
nodejs/node#44102
* test: split test-crypto-dh.js
nodejs/node#40451
* crypto: introduce X509Certificate API
nodejs/node#36804
* src: split property helpers from node::Environment
nodejs/node#44056
* nodejs/node#38905
bootstrap: implement run-time user-land snapshots via --build-snapshot and --snapshot-blob
* lib,src: implement WebAssembly Web API
nodejs/node#42701
* fixup! deps,src: use SIMD for normal base64 encoding
* fixup! src: refactor DH groups to delete crypto_groups.h
* chore: fixup base64 GN file
* fix: check that node::InitializeContext() returns true
* chore: delete _noBrowserGlobals usage
* chore: disable fetch in renderer procceses
* dns: default to verbatim=true in dns.lookup()
nodejs/node#39987
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
tniessen added a commit to tniessen/node that referenced this pull request Aug 27, 2023
This test is not specific to modp1 at all, it might as well use any of
the other groups.
Refs: nodejs#40451
nodejs-github-bot pushed a commit that referenced this pull request Aug 29, 2023
This test is not specific to modp1 at all, it might as well use any of
the other groups.
Refs: #40451
PR-URL: #49348
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
This test is not specific to modp1 at all, it might as well use any of
the other groups.
Refs: #40451
PR-URL: #49348
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Nov 27, 2023
This test is not specific to modp1 at all, it might as well use any of
the other groups.
Refs: #40451
PR-URL: #49348
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
This test is not specific to modp1 at all, it might as well use any of
the other groups.
Refs: nodejs/node#40451
PR-URL: nodejs/node#49348
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
This test is not specific to modp1 at all, it might as well use any of
the other groups.
Refs: nodejs/node#40451
PR-URL: nodejs/node#49348
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@joyeecheung@nodejs-github-bot@Trott@cjihrig@Mesteery