Skip to content

[v14.x backport] deps: add corepack - #40479

Closed
aduh95 wants to merge 3 commits into
nodejs:v14.x-stagingfrom
aduh95:backport-corepack
Closed

[v14.x backport] deps: add corepack#40479
aduh95 wants to merge 3 commits into
nodejs:v14.x-stagingfrom
aduh95:backport-corepack

Conversation

@aduh95

@aduh95aduh95 commented Oct 16, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Bakport of #39608 and #40374.
EDIT: and #41060.

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. v14.x labels Oct 16, 2021
@targostargos added the semver-minor PRs that contain new features and should be released in the next minor version. label Oct 16, 2021
@aduh95aduh95 mentioned this pull request Oct 18, 2021
Closed
richardlau
richardlau reviewed Dec 7, 2021
View reviewed changes
Comment threadconfigure.py Outdated
@richardlau

richardlau commented Dec 7, 2021

Copy link
Copy Markdown
Member

@nodejs/lts Are we comfortable landing this in 14 LTS now it is in maintenance?

@mhdawson

mhdawson commented Dec 7, 2021

Copy link
Copy Markdown
Member

I'll add to @richardlau's question, has there been an ask to backport?

@aduh95

aduh95 commented Dec 8, 2021

Copy link
Copy Markdown
ContributorAuthor

has there been an ask to backport?

I guess I'm asking for it with this PR.

@arcanis Do you have any thoughts on Corepack making it or not to v14.x?

@arcanis

arcanis commented Dec 8, 2021

Copy link
Copy Markdown
Contributor

I think it'd be great, since with Node 12 being out of the picture in May it would help providing consistent and portable install instructions for Yarn (we already recommend it if possible, but since Yarn 3 supports Node 12+ and Yarn 4 will support 14+, there's always a good portion of our users which will need other means).

And given it's still opt-in, it should be fairly low-risk (the Corepack tests run on 14+, so it shouldn't have compat issues).

aduh95
aduh95 commented Dec 8, 2021
View reviewed changes
Comment threadconfigure.py Outdated
Comment threadconfigure.py Outdated
arcanisand others added 3 commits January 14, 2022 18:14
@arcanis@aduh95
deps: add corepack
a5fe87d
Corepack provides shims for Yarn and pnpm in order to soften the
developer experience when working on Node projects.
Refs: https://github.com/nodejs/node/issues/15244
Refs: nodejs/TSC#904
PR-URL: nodejs#39608
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@arcanis@aduh95
deps: upgrade Corepack to 0.10
045f839
PR-URL: nodejs#40374
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jonahsnider@aduh95
build: add --without-corepack
a487d29
PR-URL: nodejs#41060
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@richardlaurichardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 25, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 25, 2022
@nodejs-github-bot

nodejs-github-bot commented Jan 25, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42135/

richardlau pushed a commit that referenced this pull request Jan 25, 2022
@arcanis@richardlau
deps: add corepack
737df75
Corepack provides shims for Yarn and pnpm in order to soften the
developer experience when working on Node projects.
Refs: https://github.com/nodejs/node/issues/15244
Refs: nodejs/TSC#904
PR-URL: #39608
Backport-PR-URL: #40479
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
richardlau pushed a commit that referenced this pull request Jan 25, 2022
@arcanis@richardlau
deps: upgrade Corepack to 0.10
cd20ecc
PR-URL: #40374
Backport-PR-URL: #40479
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau pushed a commit that referenced this pull request Jan 25, 2022
@jonahsnider@richardlau
build: add --without-corepack
0231ffa
PR-URL: #41060
Backport-PR-URL: #40479
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@richardlau

richardlau commented Jan 25, 2022

Copy link
Copy Markdown
Member

Landed in b85aa5a...0231ffa.

@aduh95
aduh95 deleted the backport-corepack branch January 25, 2022 18:52
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlaurichardlaurichardlau approved these changes

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.metaIssues and PRs related to the general management of the project.needs-ciPRs that need a full CI run.semver-minorPRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@aduh95@richardlau@mhdawson@arcanis@nodejs-github-bot@targos@jonahsnider