Uh oh!
There was an error while loading. Please reload this page.
test: add semicolon after chunk size - #40487
Closed
lpinca wants to merge 1 commit into
Closed
Conversation
MemberAuthor
|
lpincaforce-pushed
the
add/semicolon-after-chunk-size
branch
2 times, most recently
from
October 17, 2021 11:36
dbaa93b to
5b3a3acCompareThe ABNF for chunk extensions as per RFC 7230 is chunk-ext = *( ";" chunk-ext-name [ "=" chunk-ext-val ] ) chunk-ext-name = token chunk-ext-val = token / quoted-string Add a semicolon after the chunk size for clarity. This does not invalidate the test as it verifies that the HTTP parser does not ignore chunk extensions. Refs: https://grenfeldt.dev/2021/10/08/gunicorn-20.1.0-public-disclosure-of-request-smuggling
lpincaforce-pushed
the
add/semicolon-after-chunk-size
branch
from
October 19, 2021 18:23
5b3a3ac to
c7ee409Comparenodejs-github-bot
commented
Oct 19, 2021
Collaborator
27 tasks
jasnell
approved these changes
Oct 20, 2021
This was referenced Oct 21, 2021
nodejs-github-bot
commented
Nov 3, 2021
Collaborator
44 tasks
nodejs-github-bot
commented
Nov 4, 2021
Collaborator
This was referenced Nov 5, 2021
nodejs-github-bot
commented
Nov 6, 2021
Collaborator
lpinca added a commit
that referenced
this pull request
Nov 6, 2021
The ABNF for chunk extensions as per RFC 7230 is chunk-ext = *( ";" chunk-ext-name [ "=" chunk-ext-val ] ) chunk-ext-name = token chunk-ext-val = token / quoted-string Add a semicolon after the chunk size for clarity. This does not invalidate the test as it verifies that the HTTP parser does not ignore chunk extensions. PR-URL: #40487 Refs: https://grenfeldt.dev/2021/10/08/gunicorn-20.1.0-public-disclosure-of-request-smuggling Reviewed-By: James M Snell <jasnell@gmail.com>
lpinca
commented
Nov 6, 2021
MemberAuthor
Landed in 19839f8. |
targos pushed a commit
that referenced
this pull request
Nov 6, 2021
The ABNF for chunk extensions as per RFC 7230 is chunk-ext = *( ";" chunk-ext-name [ "=" chunk-ext-val ] ) chunk-ext-name = token chunk-ext-val = token / quoted-string Add a semicolon after the chunk size for clarity. This does not invalidate the test as it verifies that the HTTP parser does not ignore chunk extensions. PR-URL: #40487 Refs: https://grenfeldt.dev/2021/10/08/gunicorn-20.1.0-public-disclosure-of-request-smuggling Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Nov 7, 2021
23 tasks
26 tasks
BethGriggs pushed a commit
that referenced
this pull request
Nov 25, 2021
The ABNF for chunk extensions as per RFC 7230 is chunk-ext = *( ";" chunk-ext-name [ "=" chunk-ext-val ] ) chunk-ext-name = token chunk-ext-val = token / quoted-string Add a semicolon after the chunk size for clarity. This does not invalidate the test as it verifies that the HTTP parser does not ignore chunk extensions. PR-URL: #40487 Refs: https://grenfeldt.dev/2021/10/08/gunicorn-20.1.0-public-disclosure-of-request-smuggling Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ABNF for chunk extensions as per RFC 7230 is
Add a semicolon after the chunk size for clarity.
This does not invalidate the test as it verifies that the HTTP parser
does not ignore chunk extensions.
Refs: https://grenfeldt.dev/2021/10/08/gunicorn-20.1.0-public-disclosure-of-request-smuggling