Uh oh!
There was an error while loading. Please reload this page.
doc: explain backport labels - #40520
Merged
Merged
Conversation
richardlau
approved these changes
Oct 19, 2021
tniessen
commented
Oct 19, 2021
Member
Could you format this to match #40358? |
targos
approved these changes
Oct 19, 2021
Qardforce-pushed
the
document-backport-labels
branch
from
October 19, 2021 16:36
b7d7849 to
ab4b9acCompareQard
commented
Oct 19, 2021
MemberAuthor
@tniessen Done. Didn't know that existed. 😅 |
Qardforce-pushed
the
document-backport-labels
branch
from
October 19, 2021 16:42
ab4b9ac to
e051a02CompareQard
commented
Oct 19, 2021
MemberAuthor
Just one more tiny fix to arrange it alphabetically. :) |
lpinca
approved these changes
Oct 19, 2021
Contributor
Fast-track has been requested by @lpinca. Please 👍 to approve. |
aduh95
approved these changes
Oct 20, 2021
aduh95
commented
Oct 20, 2021
Contributor
There could be a comment regarding |
jasnell
approved these changes
Oct 20, 2021
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/40520 ✔ Done loading data for nodejs/node/pull/40520 ----------------------------------- PR info ------------------------------------ Title doc: explain backport labels (#40520) Author Stephen Belanger (@Qard) Branch Qard:document-backport-labels -> nodejs:master Labels doc, fast-track Commits 1 - doc: explain backport labels Committers 1 - Stephen Belanger PR-URL: https://github.com/nodejs/node/pull/40520 Reviewed-By: Richard Lau Reviewed-By: Tobias Nießen Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca Reviewed-By: Antoine du Hamel Reviewed-By: Michael Dawson Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40520 Reviewed-By: Richard Lau Reviewed-By: Tobias Nießen Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca Reviewed-By: Antoine du Hamel Reviewed-By: Michael Dawson Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 19 Oct 2021 15:40:34 GMT ✔ Approvals: 7 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/40520#pullrequestreview-783489714 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/40520#pullrequestreview-783532267 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/40520#pullrequestreview-783510129 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/40520#pullrequestreview-783639459 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/40520#pullrequestreview-784251470 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/40520#pullrequestreview-784562298 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/40520#pullrequestreview-784776392 ℹ This PR is being fast-tracked ✖ GitHub CI is still running ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1364900936 |
nodejs-github-bot
commented
Oct 20, 2021
Collaborator
nodejs-github-bot
commented
Oct 20, 2021
Collaborator
30 tasks
28 tasks
nodejs-github-bot
commented
Oct 22, 2021
Collaborator
PR-URL: #40520 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95force-pushed
the
document-backport-labels
branch
from
October 22, 2021 22:08
e051a02 to
f743054Compareaduh95
commented
Oct 22, 2021
Contributor
Landed in f743054 |
31 tasks
targos pushed a commit
that referenced
this pull request
Oct 23, 2021
PR-URL: #40520 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Oct 24, 2021
BethGriggs pushed a commit
that referenced
this pull request
Nov 24, 2021
PR-URL: #40520 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just adding a list of relevant labels to the backport guide to make it easier to understand how to label backport/lts issues and PRs.