Skip to content

meta: consolidate AUTHORS entries for dfabulich - #40527

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:authors-df
Closed

meta: consolidate AUTHORS entries for dfabulich#40527
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:authors-df

Conversation

@Trott

Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 19, 2021
@Trott

Copy link
Copy Markdown
MemberAuthor

@dfabulich This uses a .mailmap entry to preserve your fabulich.com email address in AUTHORS and remove your redfin.com email address there. If you'd prefer we do the opposite, please leave a comment. Thanks!

@TrottTrott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 19, 2021
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@MesteeryMesteery added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 20, 2021
@TrottTrott removed the fast-track PRs that do not need to wait for 48 hours to land. label Oct 22, 2021

@aduh95aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@TrottTrott added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 22, 2021
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 22, 2021
@github-actions

Copy link
Copy Markdown
Contributor

Landed in dd7a929...36663c9

nodejs-github-bot pushed a commit that referenced this pull request Oct 22, 2021
PR-URL: #40527
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Oct 23, 2021
PR-URL: #40527
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targostargos mentioned this pull request Nov 8, 2021
BethGriggs pushed a commit that referenced this pull request Nov 24, 2021
PR-URL: #40527
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Nov 26, 2021
1 task
@Trott
Trott deleted the authors-df branch September 25, 2022 17:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.metaIssues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott@lpinca@aduh95@nodejs-github-bot@Mesteery