Skip to content

update license-builder for OpenSSL and run it - #40540

Closed
Trott wants to merge 2 commits into
nodejs:masterfrom
Trott:license-builder
Closed

update license-builder for OpenSSL and run it#40540
Trott wants to merge 2 commits into
nodejs:masterfrom
Trott:license-builder

Conversation

@Trott

@TrottTrott commented Oct 21, 2021

Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-botnodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Oct 21, 2021
@TrottTrott mentioned this pull request Oct 21, 2021
Merged
targos
targos reviewed Oct 21, 2021
View reviewed changes
Comment threadtools/license-builder.sh Outdated
@MesteeryMesteery added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 21, 2021
mhdawson
mhdawson approved these changes Oct 21, 2021
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TrottTrott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 23, 2021
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 23, 2021
@github-actions

github-actionsBot commented Oct 23, 2021

Copy link
Copy Markdown
Contributor

Landed in 80e94db...5f0031e

nodejs-github-bot pushed a commit that referenced this pull request Oct 23, 2021
@Trott@nodejs-github-bot
tools: update license-builder.sh for OpenSSL
c946e3c
PR-URL: #40540
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Oct 23, 2021
@Trott@nodejs-github-bot
doc: run license-builder
5f0031e
PR-URL: #40540
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request Oct 23, 2021
@Trott@targos
tools: update license-builder.sh for OpenSSL
c2265a9
PR-URL: #40540
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request Oct 23, 2021
@Trott@targos
doc: run license-builder
6e39e0e
PR-URL: #40540
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targostargos mentioned this pull request Nov 8, 2021
Merged
@Trott
Trott deleted the license-builder branch September 25, 2022 17:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targostargostargos approved these changes
@cjihrigcjihrigcjihrig approved these changes
@tniessentniessentniessen approved these changes
@richardlaurichardlaurichardlau approved these changes
+1 more reviewer
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.metaIssues and PRs related to the general management of the project.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Trott@targos@cjihrig@tniessen@richardlau@mhdawson@nodejs-github-bot@Mesteery