Skip to content

stream: remove no longer necessary ComposeDuplex - #40545

Closed
ronag wants to merge 1 commit into
nodejs:masterfrom
nxtedition:compose-duplex
Closed

stream: remove no longer necessary ComposeDuplex#40545
ronag wants to merge 1 commit into
nodejs:masterfrom
nxtedition:compose-duplex

Conversation

@ronag

Copy link
Copy Markdown
Member

No description provided.

@ronagronag added stream Issues and PRs related to the stream subsystem. dont-land-on-v12.x labels Oct 21, 2021
@ronag

Copy link
Copy Markdown
MemberAuthor

@nodejs/streams

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 21, 2021

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronagronag added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 21, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 21, 2021
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@ronagronag added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 21, 2021
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@ronagronag removed the needs-ci PRs that need a full CI run. label Oct 21, 2021
@nodejs-github-bot

nodejs-github-bot commented Oct 21, 2021

Copy link
Copy Markdown
Collaborator

@ronagronag added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 23, 2021
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 23, 2021
@github-actions

Copy link
Copy Markdown
Contributor

Landed in 9843885...47fb867

nodejs-github-bot pushed a commit that referenced this pull request Oct 23, 2021
PR-URL: #40545
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos pushed a commit that referenced this pull request Nov 6, 2021
PR-URL: #40545
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@targostargos mentioned this pull request Nov 8, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.streamIssues and PRs related to the stream subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@ronag@nodejs-github-bot@mcollina@benjamingr@lpinca@tniessen