Skip to content

http: add mising initialization - #40555

Closed
mhdawson wants to merge 3 commits into
nodejs:masterfrom
mhdawson:coverity-4
Closed

http: add mising initialization#40555
mhdawson wants to merge 3 commits into
nodejs:masterfrom
mhdawson:coverity-4

Conversation

@mhdawson

Copy link
Copy Markdown
Member

Add missing initialization reported by coverity scan.

Signed-off-by: Michael Dawson mdawson@devrus.com

Add missing initialization reported by coverity scan.
Signed-off-by: Michael Dawson <mdawson@devrus.com>
@mhdawson
mhdawson requested a review from jasnellOctober 21, 2021 20:58
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Oct 21, 2021
@mhdawson

Copy link
Copy Markdown
MemberAuthor

@jasnell I think moving the env_ makes sense but hoping you can easily confirm/correct.

@addaleaxaddaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasnell I think moving the env_ makes sense but hoping you can easily confirm/correct.

@mhdawson Moving a pointer doesn’t do anything (except maybe look odd).

Signed-off-by: Michael Dawson <mdawson@devrus.com>
@mhdawson

Copy link
Copy Markdown
MemberAuthor

@addaleax thanks, pushed a commit to remove the move.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@tniessen

Copy link
Copy Markdown
Member

Nit: typo in commit message

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

mhdawson added a commit that referenced this pull request Nov 12, 2021
Add missing initialization reported by coverity scan.
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #40555
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@mhdawson

Copy link
Copy Markdown
MemberAuthor

Landed in 055a38b4c7db64ab1461cd44b7605d5b020ab382

targos pushed a commit that referenced this pull request Nov 21, 2021
Add missing initialization reported by coverity scan.
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #40555
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targostargos mentioned this pull request Nov 26, 2021
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
Add missing initialization reported by coverity scan.
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #40555
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
Add missing initialization reported by coverity scan.
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #40555
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@danielleadamsdanielleadams mentioned this pull request Feb 1, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@mhdawson@nodejs-github-bot@tniessen@addaleax