dgram: fix send with out of bounds offset + length

[Linkgoron]

fix Socket.prototype.send sending garbage when the message is a string, and offset+length is out of bounds.

When a string message was sent with offset/length, the underlying buffer from Buffer.from was sent without checking the original string's length, and garbage was sent if length/offset were too long. Instead, the method now throws an ERR_OUT_OF_RANGEERR_BUFFER_OUT_OF_BOUNDS error.

Edit:
Also added checks for Buffers

Fixes: #40491

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/40407/

[mscdex]

Do we need to do the same checks for non-strings as well? The same test file verifies errors are thrown for some ranges, but I'm not sure if it covers all cases.

[Linkgoron]

Do we need to do the same checks for non-strings as well? The same test file verifies errors are thrown for some ranges, but I'm not sure if it covers all cases.

I think you're correct and that the following (for example) might show a similar error:

sock.send(Buffer.from('hello'),3,4);

Maybe I should add the check for all inputs.

[Linkgoron]

Do we need to do the same checks for non-strings as well? The same test file verifies errors are thrown for some ranges, but I'm not sure if it covers all cases.

It looks like in addition to strings, checks for Buffers in general were missing, and I also found a minor edge case for DataView which uses data that it should not use (if byteOffset is used on the DataView, it still uses extra data in the buffer). I've used ERR_BUFFER_OUT_OF_BOUNDS in order to keep the Errors for the covered cases the same as they were in previous versions (instead of ERR_OUT_OF_RANGE).

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/40409/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/40413/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/40422/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/40448/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/40450/ ✅

[github-actions]

Landed in 3b9044b...2413283