Skip to content

doc: correct esm spec package scope lookup definition - #40592

Closed
guybedford wants to merge 1 commit into
nodejs:masterfrom
guybedford:spec-scope-fix
Closed

doc: correct esm spec package scope lookup definition#40592
guybedford wants to merge 1 commit into
nodejs:masterfrom
guybedford:spec-scope-fix

Conversation

@guybedford

@guybedfordguybedford commented Oct 24, 2021•
edited by aduh95
Loading

Copy link
Copy Markdown
Contributor

This corrects the logic in the READ_PACKAGE_SCOPE method where it was returning the parsed package.json contents instead of the URL followed by a second read phase. In the process READ_PACKAGE_SCOPE has been renamed to LOOKUP_PACKAGE_SCOPE to more clearly reflect the definition of this return value.

Fixes: #40578

@nodejs/modules

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. labels Oct 24, 2021
@guybedfordguybedford mentioned this pull request Oct 24, 2021
Closed
1 task
@MesteeryMesteery added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 25, 2021
@guybedford

guybedford commented Oct 26, 2021

Copy link
Copy Markdown
ContributorAuthor

Landed in 687debb.

@guybedford
guybedford deleted the spec-scope-fix branch October 26, 2021 23:03
guybedford added a commit that referenced this pull request Oct 26, 2021
@guybedford
doc: correct esm spec scope lookup definition
687debb
PR-URL: #40592Fixes: #40578
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
targos pushed a commit that referenced this pull request Nov 6, 2021
@guybedford@targos
doc: correct esm spec scope lookup definition
6ae134e
PR-URL: #40592Fixes: #40578
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
@targostargos mentioned this pull request Nov 8, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 29, 2022
@guybedford@danielleadams
doc: correct esm spec scope lookup definition
5c90975
PR-URL: #40592Fixes: #40578
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
@danielleadamsdanielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GeoffreyBoothGeoffreyBoothGeoffreyBooth approved these changes
@targostargostargos approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.esmIssues and PRs related to the ECMAScript Modules implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

doc: READ_PACKAGE_SCOPE returns JSON not a URL

6 participants

@guybedford@GeoffreyBooth@targos@aduh95@nodejs-github-bot@Mesteery