Skip to content

meta: consolidate AUTHORS entries for brettkiefer - #40599

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:authors-bk
Closed

meta: consolidate AUTHORS entries for brettkiefer#40599
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:authors-bk

Conversation

@Trott

@TrottTrott commented Oct 25, 2021

Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 25, 2021
@Trott

Trott commented Oct 25, 2021

Copy link
Copy Markdown
MemberAuthor

@brettkiefer This uses a .mailmap entry to use your gmail.com address in favor of your trello.com address in AUTHORS. If you'd prefer the other way around, please leave a comment. Thanks!

@TrottTrott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 25, 2021
@github-actions

This comment has been minimized.

Sign in to view
@Trott
Trott requested review from lpinca and tniessenOctober 28, 2021 00:18
@TrottTrott removed the fast-track PRs that do not need to wait for 48 hours to land. label Oct 28, 2021
@Trott

Trott commented Oct 28, 2021

Copy link
Copy Markdown
MemberAuthor

This is the last of these consolidation PRs. Needs some reviews. Help?

@Trott
Trott requested a review from jasnellOctober 28, 2021 15:35
@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 28, 2021
@TrottTrott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 30, 2021
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 30, 2021
@github-actions

github-actionsBot commented Oct 30, 2021

Copy link
Copy Markdown
Contributor

Landed in e937662...babd73c

nodejs-github-bot pushed a commit that referenced this pull request Oct 30, 2021
@Trott@nodejs-github-bot
meta: consolidate AUTHORS entries for brettkiefer
babd73c
PR-URL: #40599
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@Trott
Trott deleted the authors-bk branch October 30, 2021 00:38
targos pushed a commit that referenced this pull request Nov 6, 2021
@Trott@targos
meta: consolidate AUTHORS entries for brettkiefer
aa98c6b
PR-URL: #40599
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@targostargos mentioned this pull request Nov 8, 2021
Merged
BethGriggs pushed a commit that referenced this pull request Nov 25, 2021
@Trott@BethGriggs
meta: consolidate AUTHORS entries for brettkiefer
ef46cb4
PR-URL: #40599
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Nov 26, 2021
Merged
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincaAwaiting requested review from lpinca
@tniessentniessenAwaiting requested review from tniessen
+1 more reviewer
@MylesBorinsMylesBorinsMylesBorins approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.metaIssues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Trott@jasnell@MylesBorins@nodejs-github-bot