Skip to content

tools: fix formatting of warning message in update-authors.js - #40600

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:bracket-fix
Closed

tools: fix formatting of warning message in update-authors.js#40600
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:bracket-fix

Conversation

@Trott

Copy link
Copy Markdown
Member

The email already has < and > surrounding it so adding it results in
a misformatted message.

The email already has `<` and `>` surrounding it so adding it results in
a misformatted message.
@TrottTrott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 25, 2021
@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 25, 2021
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 25, 2021
@lpincalpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 26, 2021
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 26, 2021
@github-actions

Copy link
Copy Markdown
Contributor

Landed in 9ebdba4...d4842e6

nodejs-github-bot pushed a commit that referenced this pull request Oct 26, 2021
The email already has `<` and `>` surrounding it so adding it results in
a misformatted message.
PR-URL: #40600
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Nov 6, 2021
The email already has `<` and `>` surrounding it so adding it results in
a misformatted message.
PR-URL: #40600
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targostargos mentioned this pull request Nov 8, 2021
BethGriggs pushed a commit that referenced this pull request Nov 25, 2021
The email already has `<` and `>` surrounding it so adding it results in
a misformatted message.
PR-URL: #40600
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Nov 26, 2021
1 task
@Trott
Trott deleted the bracket-fix branch September 25, 2022 17:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.toolsIssues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott@lpinca@cjihrig@VoltrexKeyva@nodejs-github-bot