Skip to content

meta: consolidate AUTHORS entries for alexzherdev - #40620

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:authors-az
Closed

meta: consolidate AUTHORS entries for alexzherdev#40620
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:authors-az

Conversation

@Trott

Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 27, 2021
@Trott

Copy link
Copy Markdown
MemberAuthor

@alexzherdev This uses a .mailmap entry to remove your acl.com email from AUTHORS and leave your gmail.com address. If you'd prefer we do something else, please comment. Thanks!

@TrottTrott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 27, 2021
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@alexzherdev

Copy link
Copy Markdown
Contributor

@Trott The acl.com address doesn't belong to me anymore. Could we remove it altogether? Thanks!

@Trott

Copy link
Copy Markdown
MemberAuthor

@Trott The acl.com address doesn't belong to me anymore. Could we remove it altogether? Thanks!

Yes, that's what this basically does. The .mailmap entry says "if you see this acl.com address, use this gmail.com address instead."

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 27, 2021
@jasnelljasnell added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 28, 2021
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 28, 2021
@github-actions

Copy link
Copy Markdown
Contributor

Landed in 3a74481...1306d5c

nodejs-github-bot pushed a commit that referenced this pull request Oct 28, 2021
PR-URL: #40620
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Nov 6, 2021
PR-URL: #40620
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Nov 8, 2021
BethGriggs pushed a commit that referenced this pull request Nov 25, 2021
PR-URL: #40620
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Nov 26, 2021
1 task
@Trott
Trott deleted the authors-az branch September 25, 2022 17:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.metaIssues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@Trott@alexzherdev@jasnell@lpinca@tniessen@nodejs-github-bot