Skip to content

deps: upgrade npm to 8.1.2 - #40643

Closed
npm-robot wants to merge 1 commit into
nodejs:masterfrom
npm:npm-8.1.2
Closed

deps: upgrade npm to 8.1.2#40643
npm-robot wants to merge 1 commit into
nodejs:masterfrom
npm:npm-8.1.2

Conversation

@npm-robot

@npm-robotnpm-robot commented Oct 28, 2021

Copy link
Copy Markdown
Contributor

BUG FIXES

DEPENDENCIES

@nodejs-github-botnodejs-github-bot added dont-land-on-v12.x fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry. labels Oct 28, 2021
@github-actions

github-actionsBot commented Oct 28, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @nodejs-github-bot. Please 👍 to approve.

@richardlaurichardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2021
@MesteeryMesteery removed the needs-ci PRs that need a full CI run. label Oct 28, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@TrottTrott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 28, 2021
@github-actionsgithub-actionsBot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 28, 2021
@github-actions

github-actionsBot commented Oct 28, 2021

Copy link
Copy Markdown
Contributor
Commit Queue failed
- Loading data for nodejs/node/pull/40643
✔ Done loading data for nodejs/node/pull/40643
----------------------------------- PR info ------------------------------------
Title deps: upgrade npm to 8.1.2 (#40643)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch npm-robot:npm-8.1.2 -> nodejs:master
Labels npm, fast-track, dont-land-on-v12.x, dont-land-on-v14.x
Commits 1
- deps: upgrade npm to 8.1.2
Committers 1
- npm team PR-URL: https://github.com/nodejs/node/pull/40643
Fixes: https://github.com/set
Fixes: https://github.com/always
Reviewed-By: Luigi Pinca Reviewed-By: Colin Ihrig Reviewed-By: Richard Lau Reviewed-By: Tobias Nießen Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/40643
Fixes: https://github.com/set
Fixes: https://github.com/always
Reviewed-By: Luigi Pinca Reviewed-By: Colin Ihrig Reviewed-By: Richard Lau Reviewed-By: Tobias Nießen Reviewed-By: Rich Trott --------------------------------------------------------------------------------
ℹ This PR was created on Thu, 28 Oct 2021 19:59:51 GMT
✔ Approvals: 5
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/40643#pullrequestreview-792368244
✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/40643#pullrequestreview-792368355
✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/40643#pullrequestreview-792370069
✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/40643#pullrequestreview-792430486
✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/40643#pullrequestreview-792487800
ℹ This PR is being fast-tracked
✔ Last GitHub Actions successful
ℹ Last Full PR CI on 2021-10-28T20:13:35Z: https://ci.nodejs.org/job/node-test-pull-request/40537/
- Querying data for job/node-test-pull-request/40537/
✔ Build data downloaded
- Querying failures of job/node-test-commit/49518/
✔ Data downloaded
✖ 8 failure(s) on the last Jenkins CI run
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1396718812

@github-actionsgithub-actionsBot mentioned this pull request Oct 29, 2021
Open
33 tasks
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@github-actionsgithub-actionsBot mentioned this pull request Oct 30, 2021
Open
35 tasks
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@github-actionsgithub-actionsBot mentioned this pull request Oct 31, 2021
Open
34 tasks
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Mesteery

Mesteery commented Oct 31, 2021

Copy link
Copy Markdown
Contributor

Shouldn't #40198 and #40317 be closed?

@targos

targos commented Oct 31, 2021

Copy link
Copy Markdown
Member

Shouldn't #40198 and #40317 be closed?

Yep I closed them, good find!

@github-actionsgithub-actionsBot mentioned this pull request Nov 1, 2021
Open
38 tasks
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@MesteeryMesteery added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 1, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@github-actionsgithub-actionsBot mentioned this pull request Nov 2, 2021
Open
35 tasks
@nodejs-github-bot

nodejs-github-bot commented Nov 2, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40649/

@Trott

Trott commented Nov 2, 2021

Copy link
Copy Markdown
Member

Landed in 229a182

@TrottTrott closed this Nov 2, 2021
Trott pushed a commit that referenced this pull request Nov 2, 2021
@npm-robot@Trott
deps: upgrade npm to 8.1.2
229a182
PR-URL: #40643
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
This was referenced Nov 3, 2021
Open
Open
Open
Open
targos pushed a commit that referenced this pull request Nov 6, 2021
@npm-robot@targos
deps: upgrade npm to 8.1.2
3805b80
PR-URL: #40643
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
@targostargos mentioned this pull request Nov 8, 2021
Merged
BethGriggs pushed a commit that referenced this pull request Nov 25, 2021
@npm-robot@BethGriggs
deps: upgrade npm to 8.1.2
c14eb23
PR-URL: #40643
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Nov 26, 2021
Merged
1 task
BethGriggs added a commit that referenced this pull request Nov 30, 2021
@BethGriggs
2021-11-30, Version 16.13.1 'Gallium' (LTS)
88cfa36
Notable changes:
- **deps**: upgrade npm to 8.1.2 (npm team)
[#40643](#40643)
- **deps**: update c-ares to 1.18.1 (Richard Lau)
[#40660](#40660)
- **doc**: add VoltrexMaster to collaborators (voltrexmaster)
[#40566](#40566)
- **lib**: fix regular expression to detect \`/\` and \`\\\`
(Francesco Trotta) [#40325](#40325)
PR-URL: #40974
BethGriggs added a commit that referenced this pull request Dec 1, 2021
@BethGriggs
2021-12-01, Version 16.13.1 'Gallium' (LTS)
12029ce
Notable changes:
- **deps**: upgrade npm to 8.1.2 (npm team)
[#40643](#40643)
- **deps**: update c-ares to 1.18.1 (Richard Lau)
[#40660](#40660)
- **doc**: add VoltrexMaster to collaborators (voltrexmaster)
[#40566](#40566)
- **lib**: fix regular expression to detect \`/\` and \`\\\`
(Francesco Trotta) [#40325](#40325)
PR-URL: #40974
BethGriggs added a commit that referenced this pull request Dec 1, 2021
@BethGriggs
2021-12-01, Version 16.13.1 'Gallium' (LTS)
6f74010
Notable changes:
- **deps**: upgrade npm to 8.1.2 (npm team)
[#40643](#40643)
- **deps**: update c-ares to 1.18.1 (Richard Lau)
[#40660](#40660)
- **doc**: add VoltrexMaster to collaborators (voltrexmaster)
[#40566](#40566)
- **lib**: fix regular expression to detect \`/\` and \`\\\`
(Francesco Trotta) [#40325](#40325)
PR-URL: #40974
@wraithgar
wraithgar deleted the npm-8.1.2 branch June 26, 2025 15:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@tniessentniessentniessen approved these changes
@richardlaurichardlaurichardlau approved these changes
+1 more reviewer
@VoltrexKeyvaVoltrexKeyvaVoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-failedAn error occurred while landing this pull request using GitHub Actions.fast-trackPRs that do not need to wait for 48 hours to land.npmIssues and PRs related to the npm client dependency or the npm registry.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@npm-robot@nodejs-github-bot@Mesteery@targos@Trott@lpinca@cjihrig@tniessen@richardlau@VoltrexKeyva