Uh oh!
There was an error while loading. Please reload this page.
tools,meta: remove exclusions from AUTHORS - #40648
Closed
Trott wants to merge 1 commit into
Closed
Conversation
The update-authors tool omits Chromium team members. This was a decision made years ago. The idea was that these folks contributed to V8 not to Node.js, as they typically ended up in our code-base via cherry-picked commits from V8. Ref: nodejs#232 (diff) Now that there are over 3000 contributors identified in AUTHORS, some of whom are bots that we run, I think it's time to undo this exception. If we used someone else's code in a cherry-pick, congratulations to them, they're authors. In particular, this will fix the omission of Yang Guo who contributed extensively to Node.js outside of V8 contributions.
aduh95
approved these changes
Oct 29, 2021
targos
approved these changes
Oct 31, 2021
Contributor
Landed in 61a73f8...1a6d927 |
nodejs-github-bot pushed a commit
that referenced
this pull request
Oct 31, 2021
The update-authors tool omits Chromium team members. This was a decision made years ago. The idea was that these folks contributed to V8 not to Node.js, as they typically ended up in our code-base via cherry-picked commits from V8. Ref: #232 (diff) Now that there are over 3000 contributors identified in AUTHORS, some of whom are bots that we run, I think it's time to undo this exception. If we used someone else's code in a cherry-pick, congratulations to them, they're authors. In particular, this will fix the omission of Yang Guo who contributed extensively to Node.js outside of V8 contributions. PR-URL: #40648 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit
that referenced
this pull request
Nov 6, 2021
The update-authors tool omits Chromium team members. This was a decision made years ago. The idea was that these folks contributed to V8 not to Node.js, as they typically ended up in our code-base via cherry-picked commits from V8. Ref: #232 (diff) Now that there are over 3000 contributors identified in AUTHORS, some of whom are bots that we run, I think it's time to undo this exception. If we used someone else's code in a cherry-pick, congratulations to them, they're authors. In particular, this will fix the omission of Yang Guo who contributed extensively to Node.js outside of V8 contributions. PR-URL: #40648 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
BethGriggs pushed a commit
that referenced
this pull request
Nov 25, 2021
The update-authors tool omits Chromium team members. This was a decision made years ago. The idea was that these folks contributed to V8 not to Node.js, as they typically ended up in our code-base via cherry-picked commits from V8. Ref: #232 (diff) Now that there are over 3000 contributors identified in AUTHORS, some of whom are bots that we run, I think it's time to undo this exception. If we used someone else's code in a cherry-pick, congratulations to them, they're authors. In particular, this will fix the omission of Yang Guo who contributed extensively to Node.js outside of V8 contributions. PR-URL: #40648 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The update-authors tool omits Chromium team members. This was a decision
made years ago. The idea was that these folks contributed to V8 not to
Node.js, as they typically ended up in our code-base via cherry-picked
commits from V8.
Ref: #232 (diff)
Now that there are over 3000 contributors identified in AUTHORS, some of
whom are bots that we run, I think it's time to undo this exception. If
we used someone else's code in a cherry-pick, congratulations to them,
they're authors. In particular, this will fix the omission of Yang
Guo who contributed extensively to Node.js outside of V8 contributions.