Uh oh!
There was an error while loading. Please reload this page.
process: refactor execution - #40664
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
aduh95
reviewed
Oct 30, 2021
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
VoltrexKeyvaforce-pushed
the
refactor-process-execution
branch
2 times, most recently
from
October 30, 2021 12:44
38f859f to
ccbb9a7Compareaduh95
commented
Oct 30, 2021
Contributor
For reference, throwing when trying to print the result of an ES module was added in #30370 (comment). |
aduh95
approved these changes
Oct 30, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
34 tasks
lpinca
approved these changes
Oct 31, 2021
38 tasks
This comment has been minimized.
This comment has been minimized.
35 tasks
JungMinu
approved these changes
Nov 2, 2021
This comment has been minimized.
This comment has been minimized.
42 tasks
This comment has been minimized.
This comment has been minimized.
• Removed unreachable code of the `evalModule()` function as an early error is thrown when the `print` parameter is a truthy value. • Make use of the nullish coalescing operator.
VoltrexKeyvaforce-pushed
the
refactor-process-execution
branch
from
November 3, 2021 13:24
ccbb9a7 to
ab93dabCompare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
44 tasks
nodejs-github-bot
commented
Nov 4, 2021
Collaborator
This was referenced Nov 5, 2021
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/40664 ✔ Done loading data for nodejs/node/pull/40664 ----------------------------------- PR info ------------------------------------ Title process: refactor execution (#40664) Author Voltrex (@VoltrexMaster) Branch VoltrexMaster:refactor-process-execution -> nodejs:master Labels process, author ready Commits 1 - process: refactor execution Committers 1 - voltrexmaster PR-URL: https://github.com/nodejs/node/pull/40664 Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca Reviewed-By: Minwoo Jung ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40664 Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca Reviewed-By: Minwoo Jung -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - process: refactor execution ℹ This PR was created on Sat, 30 Oct 2021 09:46:57 GMT ✔ Approvals: 3 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/40664#pullrequestreview-793574274 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/40664#pullrequestreview-793760306 ✔ - Minwoo Jung (@JungMinu): https://github.com/nodejs/node/pull/40664#pullrequestreview-794778135 ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2021-11-04T19:22:57Z: https://ci.nodejs.org/job/node-test-pull-request/40709/ - Querying data for job/node-test-pull-request/40709/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1429175442 |
aduh95
approved these changes
Nov 6, 2021
aduh95
commented
Nov 6, 2021
Contributor
Landed in 549a4c9 |
This was referenced Nov 7, 2021
targos pushed a commit
that referenced
this pull request
Nov 8, 2021
• Removed unreachable code of the `evalModule()` function as an early error is thrown when the `print` parameter is a truthy value. • Make use of the nullish coalescing operator. PR-URL: #40664 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
23 tasks
BethGriggs pushed a commit
that referenced
this pull request
Nov 25, 2021
• Removed unreachable code of the `evalModule()` function as an early error is thrown when the `print` parameter is a truthy value. • Make use of the nullish coalescing operator. PR-URL: #40664 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
• Removed unreachable code of the
evalModule()function as an early error is thrown when theprintparameter is a truthy value.• Make use of the nullish coalescing operator.