src: prevent extra copies of TimerWrap::TimerCb

[RaisinTen]

I noticed that we were taking TimerCb as a const& and then copying
that into the member. This is completely fine when the constructor is
called with an lvalue. However, when called with an rvalue, we can allow
the std::function to be moved into the member instead of falling back
to a copy, so I changed the constructors to take in universal
references. Also, std::function constructors can take in multiple
arguments, so I further modified the constructors to use variadic
templates.

Signed-off-by: Darshan Sen darshan.sen@postman.com

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/40683/

[RaisinTen]

I had to rebase on top of #40684 to fix the flaky tests. Can this get another review plz?

[github-actions]

Commit Queue failed

- Loading data for nodejs/node/pull/40665
✔ Done loading data for nodejs/node/pull/40665
----------------------------------- PR info ------------------------------------
Title src: prevent extra copies of `TimerWrap::TimerCb` (#40665)
Author Darshan Sen (@RaisinTen)
Branch RaisinTen:src/prevent-extra-copies-of-TimerWrap-TimerCb -> nodejs:master
Labels c++, lib / src, author ready
Commits 1
- src: prevent extra copies of `TimerWrap::TimerCb`
Committers 1
- Darshan Sen PR-URL: https://github.com/nodejs/node/pull/40665
Reviewed-By: Anna Henningsen Reviewed-By: Minwoo Jung ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/40665
Reviewed-By: Anna Henningsen Reviewed-By: Minwoo Jung --------------------------------------------------------------------------------
⚠ Commits were pushed since the last review:
⚠ - src: prevent extra copies of `TimerWrap::TimerCb`
ℹ This PR was created on Sat, 30 Oct 2021 15:56:09 GMT
✔ Approvals: 2
✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/40665#pullrequestreview-793747833
✔ - Minwoo Jung (@JungMinu): https://github.com/nodejs/node/pull/40665#pullrequestreview-794777797
✔ Last GitHub Actions successful
ℹ Last Full PR CI on 2021-11-03T13:44:37Z: https://ci.nodejs.org/job/node-test-pull-request/40683/
- Querying data for job/node-test-pull-request/40683/
✔ Build data downloaded
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/1431079248

[aduh95]

RSLGTM

[nodejs-github-bot]

Landed in 2d368da