Skip to content

test: fix test-datetime-change-notify after daylight change - #40670

Closed
PiotrRybak wants to merge 1 commit into
nodejs:masterfrom
PiotrRybak:fix-datetime-test
Closed

test: fix test-datetime-change-notify after daylight change#40670
PiotrRybak wants to merge 1 commit into
nodejs:masterfrom
PiotrRybak:fix-datetime-test

Conversation

@PiotrRybak

@PiotrRybakPiotrRybak commented Oct 31, 2021

Copy link
Copy Markdown
Contributor

Add standard timezone name for Dublin without daylight saving

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 31, 2021
@PiotrRybak

PiotrRybak commented Oct 31, 2021

Copy link
Copy Markdown
ContributorAuthor

test-linux has failed in #40669 on test-datetime-change-notfy because of today's change in timezone related to daylight saving

@targostargos added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 31, 2021
@github-actions

github-actionsBot commented Oct 31, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @targos. Please 👍 to approve.

@targos

targos commented Oct 31, 2021

Copy link
Copy Markdown
Member

@PiotrRybak thanks for the PR! Could you please update the commit message to fix the typo (notfy -> notify) ?

@PiotrRybak
test: fix test-datetime-change-notify after daylight change
db6785e
Add standard timezone name for Dublin without daylight saving
@nodejs-github-bot

nodejs-github-bot commented Oct 31, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40591/

@PiotrRybakPiotrRybak changed the title test: fix test-datetime-change-notfy after daylight changetest: fix test-datetime-change-notify after daylight changeOct 31, 2021
@PiotrRybak

PiotrRybak commented Oct 31, 2021

Copy link
Copy Markdown
ContributorAuthor

@PiotrRybak thanks for the PR! Could you please update the commit message to fix the typo (notfy -> notify) ?

Fixed it, sorry about that

@nodejs-github-bot

nodejs-github-bot commented Oct 31, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40594/

tniessen
tniessen approved these changes Oct 31, 2021
View reviewed changes
Comment threadtest/parallel/test-datetime-change-notify.js
{
timeZone: 'Europe/Dublin',
expected: /Irish/,
expected: /(Irish Standard Time|Greenwich Mean Time)/,

@tniessentniessenOct 31, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably best to avoid unnecessary groups:

Suggested change
expected: /(IrishStandardTime|GreenwichMeanTime)/,
expected: /IrishStandardTime|GreenwichMeanTime/,

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@MesteeryMesteery added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 31, 2021
@github-actionsgithub-actionsBot mentioned this pull request Nov 1, 2021
Open
38 tasks
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Nov 1, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40605/

@nodejs-github-bot

nodejs-github-bot commented Nov 1, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40606/

@nodejs-github-bot

nodejs-github-bot commented Nov 1, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40607/

@nodejs-github-bot

nodejs-github-bot commented Nov 1, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40608/

@TrottTrott mentioned this pull request Nov 1, 2021
Merged
@targostargos mentioned this pull request Nov 1, 2021
Closed
@tniessen

tniessen commented Nov 1, 2021

Copy link
Copy Markdown
Member

Note that #40684 exists now.

@Trott

Trott commented Nov 1, 2021

Copy link
Copy Markdown
Member

Note that #40684 exists now.

It retains @PiotrRybak as the author of the commit that fixes this. Thanks, @PiotrRybak!

@tniessen

tniessen commented Nov 1, 2021

Copy link
Copy Markdown
Member

For the record, this PR was effectively merged as 747ef34. Thank you for the contribution @PiotrRybak!

This was referenced Nov 2, 2021
Open
Open
Open
@kapouer

kapouer commented Nov 9, 2021

Copy link
Copy Markdown
Contributor

Could this go into 16.10.1 ?

@Trott

Trott commented Nov 9, 2021

Copy link
Copy Markdown
Member

@targos Should the lts-watch label go on #40684 instead, since that's the PR where this change was landed? This PR was closed without merging/landing.

@targos

targos commented Nov 9, 2021

Copy link
Copy Markdown
Member

Right, thanks.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@targostargostargos approved these changes
@tniessentniessentniessen approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@PiotrRybak@targos@nodejs-github-bot@tniessen@Trott@kapouer@lpinca@Mesteery